- Add a class index to the classes.

- Add a class index to the classes.
- Add a class table which assigns individual ids to classes.
Committed: https://code.google.com/p/dart/source/detail?r=7183

[siva, 2012-04-02 18:29:21]

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/class_table.h
File vm/class_table.h (right):

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/class_table.h#newcode27
vm/class_table.h:27: void Register(const Class& cls);
Need a VisitObjectPointers function here to traverse the objects.

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/class_table.h#newcode37
vm/class_table.h:37: RawClass** table_;
DISALLOW_COPY........ stuff.

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/object.h
File vm/object.h (right):

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/object.h#newcode3859
vm/object.h:3859: RawObject::ClassTag::decode(raw_->ptr()->tags_));
Also assert class_table.At(RawObject::ClassTag::decode(raw_->ptr()->tags_) ==
result
because that is what we will be returning here right.

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/snapshot.cc
File vm/snapshot.cc (right):

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/snapshot.cc#newcode229
vm/snapshot.cc:229: const Class& cls = Class::Handle(obj);
cls_ = obj; 

That way we avoid the creation of a handle.

[Ivan Posva, 2012-04-29 21:08:25]

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/class_table.h
File vm/class_table.h (right):

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/class_table.h#newcode27
vm/class_table.h:27: void Register(const Class& cls);
On 2012/04/02 18:29:21, asiva wrote:
> Need a VisitObjectPointers function here to traverse the objects.

Done.

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/class_table.h#newcode37
vm/class_table.h:37: RawClass** table_;
On 2012/04/02 18:29:21, asiva wrote:
> DISALLOW_COPY........ stuff.

Done.

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/object.h
File vm/object.h (right):

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/object.h#newcode3859
vm/object.h:3859: RawObject::ClassTag::decode(raw_->ptr()->tags_));
On 2012/04/02 18:29:21, asiva wrote:
> Also assert class_table.At(RawObject::ClassTag::decode(raw_->ptr()->tags_) ==
> result
> because that is what we will be returning here right.

Done.

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/snapshot.cc
File vm/snapshot.cc (right):

https://chromiumcodereview.appspot.com/9965042/diff/1/vm/snapshot.cc#newcode229
vm/snapshot.cc:229: const Class& cls = Class::Handle(obj);
On 2012/04/02 18:29:21, asiva wrote:
> cls_ = obj; 
> 
> That way we avoid the creation of a handle.

Done.

[Ivan Posva, 2012-04-30 07:32:07]

Ready for review. ia32 and x64 pass all tests.

-Ivan

[siva, 2012-04-30 23:47:20]

LGTM

https://chromiumcodereview.appspot.com/9965042/diff/7018/vm/raw_object.cc
File vm/raw_object.cc (right):

https://chromiumcodereview.appspot.com/9965042/diff/7018/vm/raw_object.cc#new...
vm/raw_object.cc:34: ASSERT((tags & 0x000000f0) == 0);
We could add an assertion here that the class index is valid,
i.e the index points to a class and the class is sensible
(same checks as above which will go away when we remove the
class_ field).

[Ivan Posva, 2012-05-01 15:11:17]

http://codereview.chromium.org/9965042/diff/7018/vm/raw_object.cc
File vm/raw_object.cc (right):

http://codereview.chromium.org/9965042/diff/7018/vm/raw_object.cc#newcode34
vm/raw_object.cc:34: ASSERT((tags & 0x000000f0) == 0);
On 2012/04/30 23:47:20, asiva wrote:
> We could add an assertion here that the class index is valid,
> i.e the index points to a class and the class is sensible
> (same checks as above which will go away when we remove the
> class_ field).

Will do: See https://chromiumcodereview.appspot.com/10271032