Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 9963082: Dartc's 'can't use a type variable in static context' message now works the same way as 'NO_SUCH_TY… (Closed)

Created:
8 years, 8 months ago by zundel
Modified:
8 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Dartc's 'can't use a type variable in static context' message now works the same way as 'NO_SUCH_TYPE' The error message for can't use a type variable in a static context is useful, but it was an unconditional error. Really, the message is just a more friendly version of 'NO_SUCH_TYPE' and needs to work in the same way, being a warning in some contexts, and a compile time error in others. http://code.google.com/p/dart/issues/detail?id=2374 Committed: https://code.google.com/p/dart/source/detail?r=6146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java View 2 chunks +8 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java View 1 chunk +3 lines, -1 line 0 comments Download
M tests/co19/co19-compiler.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language.status View 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
8 years, 8 months ago (2012-04-03 19:41:14 UTC) #1
scheglov
8 years, 8 months ago (2012-04-03 19:46:36 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698