Add test for testing Socket close/error while sending response to HttpClient from HttpServer.

Add test for testing Socket close/error while sending response to HttpClient from HttpServer.
Committed: https://code.google.com/p/dart/source/detail?r=6087

[Anders Johnsen, 2012-04-02 09:22:09]

Also changed Timeout to Skip for another test, until fixed.

[Søren Gjesse, 2012-04-02 10:26:29]

lgtm

LGTM!

This is a great way of testing all kinds of error situations

https://chromiumcodereview.appspot.com/9963048/diff/1/tests/standalone/src/io...
File tests/standalone/src/io/HttpServerSocketTest.dart (right):

https://chromiumcodereview.appspot.com/9963048/diff/1/tests/standalone/src/io...
tests/standalone/src/io/HttpServerSocketTest.dart:55: class SocketImpl
implements Socket {
Maybe call this ScoketMock. Same for ServerSocketImpl.

https://chromiumcodereview.appspot.com/9963048/diff/1/tests/standalone/src/io...
tests/standalone/src/io/HttpServerSocketTest.dart:74: if (asError) _onError(new
Exception("Socket closed unexpected"));
Please format with {}s

https://chromiumcodereview.appspot.com/9963048/diff/1/tests/standalone/src/io...
tests/standalone/src/io/HttpServerSocketTest.dart:84: 
Maybe add an implementation of writeList which throws an exception as it is not
currently expected to be called. It will of cause give an method not found
exception already.

https://chromiumcodereview.appspot.com/9963048/diff/1/tests/standalone/src/io...
tests/standalone/src/io/HttpServerSocketTest.dart:170: HttpServer server = new
HttpServer();
You should be able to have the http server outside testContent, and re-use the
same server for several requests. Not sure if it add much to the test though.

[Anders Johnsen, 2012-04-02 10:40:31]

Committing.

https://chromiumcodereview.appspot.com/9963048/diff/1/tests/standalone/src/io...
File tests/standalone/src/io/HttpServerSocketTest.dart (right):

https://chromiumcodereview.appspot.com/9963048/diff/1/tests/standalone/src/io...
tests/standalone/src/io/HttpServerSocketTest.dart:55: class SocketImpl
implements Socket {
On 2012/04/02 10:26:29, Søren Gjesse wrote:
> Maybe call this ScoketMock. Same for ServerSocketImpl.

Done.

https://chromiumcodereview.appspot.com/9963048/diff/1/tests/standalone/src/io...
tests/standalone/src/io/HttpServerSocketTest.dart:74: if (asError) _onError(new
Exception("Socket closed unexpected"));
On 2012/04/02 10:26:29, Søren Gjesse wrote:
> Please format with {}s

Done.

https://chromiumcodereview.appspot.com/9963048/diff/1/tests/standalone/src/io...
tests/standalone/src/io/HttpServerSocketTest.dart:84: 
On 2012/04/02 10:26:29, Søren Gjesse wrote:
> Maybe add an implementation of writeList which throws an exception as it is
not
> currently expected to be called. It will of cause give an method not found
> exception already.

There's quite a few methods that I have not implemented, so my "style" here is
to rely on method not found exceptions.

https://chromiumcodereview.appspot.com/9963048/diff/1/tests/standalone/src/io...
tests/standalone/src/io/HttpServerSocketTest.dart:170: HttpServer server = new
HttpServer();
On 2012/04/02 10:26:29, Søren Gjesse wrote:
> You should be able to have the http server outside testContent, and re-use the
> same server for several requests. Not sure if it add much to the test though.

I agree, let's take it out. It may expose some interesting issues!