Issue 9961019: Implement context cloning in new compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9961019: Implement context cloning in new compiler. (Closed)

Created:
8 years, 8 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement context cloning in new compiler. Committed: https://code.google.com/p/dart/source/detail?r=6206

Patch Set 3 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -1 line)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1 2	2 chunks	+13 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	2 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/9961019/diff/3002/runtime/vm/flow_graph_compiler_x64.cc File runtime/vm/flow_graph_compiler_x64.cc (right): https://chromiumcodereview.appspot.com/9961019/diff/3002/runtime/vm/flow_graph_compiler_x64.cc#newcode824 runtime/vm/flow_graph_compiler_x64.cc:824: __ popq(RAX); // Get result (cloned context).nn .nn?

8 years, 8 months ago (2012-04-04 22:37:19 UTC) #2

srdjan

8 years, 8 months ago (2012-04-04 23:10:22 UTC) #3

https://chromiumcodereview.appspot.com/9961019/diff/3002/runtime/vm/flow_grap...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://chromiumcodereview.appspot.com/9961019/diff/3002/runtime/vm/flow_grap...
runtime/vm/flow_graph_compiler_x64.cc:824: __ popq(RAX);  // Get result (cloned
context).nn
On 2012/04/04 22:37:19, regis wrote:
> .nn?

An I wondered why the review did not jump to next change, even though I pressed
n .. repeatedly .. removed

Expand Messages | Collapse Messages

Issue 9961019: Implement context cloning in new compiler. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages