Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Issue 9961003: Update status file. (Closed)

Created:
8 years, 8 months ago by floitsch
Modified:
8 years, 8 months ago
Reviewers:
ahe, srdjan, ngeoffray
CC:
reviews_dartlang.org, ngeoffray, karlklose, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : FunctionTest failure is static and not dynamic. #

Patch Set 3 : Another update. #

Patch Set 4 : Better comments. #

Patch Set 5 : More status file updates. #

Patch Set 6 : Forgot to save file... #

Total comments: 6

Patch Set 7 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M tests/co19/co19-leg.status View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M tests/language/language-leg.status View 1 2 3 4 5 6 4 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
floitsch
8 years, 8 months ago (2012-04-04 13:18:24 UTC) #1
floitsch
8 years, 8 months ago (2012-04-04 18:54:35 UTC) #2
floitsch
Adding srdjan for the co19-runtime.status file changes. Note: int.toStringAs{Exponential|Fixed|Precision} currently just invoke double.toStringAs(...). I think ...
8 years, 8 months ago (2012-04-04 19:33:54 UTC) #3
ahe
LGTM! Thanks for keeping it tidy! Cheers, Peter https://chromiumcodereview.appspot.com/9961003/diff/8001/tests/language/language-leg.status File tests/language/language-leg.status (right): https://chromiumcodereview.appspot.com/9961003/diff/8001/tests/language/language-leg.status#newcode69 tests/language/language-leg.status:69: ListLiteral4Test: ...
8 years, 8 months ago (2012-04-10 12:36:31 UTC) #4
floitsch
https://chromiumcodereview.appspot.com/9961003/diff/8001/tests/language/language-leg.status File tests/language/language-leg.status (right): https://chromiumcodereview.appspot.com/9961003/diff/8001/tests/language/language-leg.status#newcode69 tests/language/language-leg.status:69: ListLiteral4Test: Fail # Illegal argument(s): 0 -- tests dynamic ...
8 years, 8 months ago (2012-04-10 14:26:57 UTC) #5
ngeoffray
8 years, 8 months ago (2012-04-16 15:00:10 UTC) #6
LGTM!

Powered by Google App Engine
This is Rietveld 408576698