Issue 9959145: Triage client/dom test failures on FireFox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9959145: Triage client/dom test failures on FireFox (Closed)

Created:
8 years, 8 months ago by sra1

Modified:
8 years, 8 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Triage client/dom test failures on FireFox 14 tests fail with frog All tests hang with dart2js BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6261

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : merge #

Patch Set 5 : merge #

Patch Set 6 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -1 line)			Patch
	M	client/tests/client/client.status	View	1 2 3 4 5	2 chunks	+33 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 8 months ago (2012-04-04 15:43:56 UTC) #2

LGTM other than spacing weirdness.

https://chromiumcodereview.appspot.com/9959145/diff/1001/client/tests/client/...
File client/tests/client/client.status (right):

https://chromiumcodereview.appspot.com/9959145/diff/1001/client/tests/client/...
client/tests/client/client.status:19: 
Did you mean to add the extra new line here and below?  One empty line seems to
be the convention elsewhere in this file.

https://chromiumcodereview.appspot.com/9959145/diff/1001/client/tests/client/...
client/tests/client/client.status:54: 
Ditto on extra newline.

https://chromiumcodereview.appspot.com/9959145/diff/1001/client/tests/client/...
client/tests/client/client.status:63: dom/ExceptionsTest: Fail      # Uses
webkitotifications, no analogue in moz
s/webkitotifications/webkitNotifications/

Expand Messages | Collapse Messages