Implement StringConcatNode in flow graph builder (it is ised on for "+" on strings, will be soon re…

Implement StringConcatNode in flow graph builder (it is ised on for "+" on strings, will be soon removed).
Committed: https://code.google.com/p/dart/source/detail?r=6179

[regis, 2012-04-04 01:58:48]

LGTM

https://chromiumcodereview.appspot.com/9959134/diff/3002/runtime/vm/flow_grap...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/9959134/diff/3002/runtime/vm/flow_grap...
runtime/vm/flow_graph_builder.cc:330: UNIMPLEMENTED();
A compile time error needs to be reported here. I guess there is no mechanism
yet to report a compile time error from the graph, but this should suffice:

  error ^= concatenated;
  Isolate::Current()->long_jump_base()->Jump(1, error);

If you need to add a formatted message, you could call
Parser::FormatErrorWithAppend

[srdjan, 2012-04-04 17:09:37]

Thanks for the review.

https://chromiumcodereview.appspot.com/9959134/diff/3002/runtime/vm/flow_grap...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/9959134/diff/3002/runtime/vm/flow_grap...
runtime/vm/flow_graph_builder.cc:330: UNIMPLEMENTED();
On 2012/04/04 01:58:48, regis wrote:
> A compile time error needs to be reported here. I guess there is no mechanism
> yet to report a compile time error from the graph, but this should suffice:
> 
>   error ^= concatenated;
>   Isolate::Current()->long_jump_base()->Jump(1, error);
> 
> If you need to add a formatted message, you could call
> Parser::FormatErrorWithAppend
> 

Discussed offline, changing it to UNREACHABLE. The flow graph builder,should not
report any errors, it's parser's job. This code also belongs rather in the
parser, but since it will be obsoleted soon, will not move it there. In
addition, this error should not be possible (calling internal method with known
arguments).