Issue 9959127: New compiler: implement switch/case in graph builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9959127: New compiler: implement switch/case in graph builder. (Closed)

Created:
8 years, 8 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

New compiler: implement switch/case in graph builder. Committed: https://code.google.com/p/dart/source/detail?r=6180

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -3 lines)			Patch
M	runtime/vm/ast.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	1 chunk	+134 lines, -2 lines	0 comments	Download
M	runtime/vm/scopes.h	View	1	3 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/9959127/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/9959127/diff/1/runtime/vm/flow_graph_builder.cc#newcode794 runtime/vm/flow_graph_builder.cc:794: ASSERT(!is_open()); Can you move this ASSERT up inside ...

8 years, 8 months ago (2012-04-04 01:31:08 UTC) #2

srdjan

8 years, 8 months ago (2012-04-04 17:33:00 UTC) #3

https://chromiumcodereview.appspot.com/9959127/diff/1/runtime/vm/flow_graph_b...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/9959127/diff/1/runtime/vm/flow_graph_b...
runtime/vm/flow_graph_builder.cc:794: ASSERT(!is_open());
On 2012/04/04 01:31:08, regis wrote:
> Can you move this ASSERT up inside the loop? Each for_case_expression should
be
> closed, right?

Discussed offline, leaving it here. Checking that we have added a fragment to
'this' EffectGraphVisitor' which has closed it.

Expand Messages | Collapse Messages

Issue 9959127: New compiler: implement switch/case in graph builder. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages