Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 9959110: Prevent NPE in TypeAnalyzer (Closed)

Created:
8 years, 8 months ago by zundel
Modified:
8 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Prevent NPE in TypeAnalyzer This came from a bug report in the editor without a specific repro case, so I just added protection at the several places on the line where fetching the type arguments might hit a null pointer. If I had a repro case, I would work on preventing the null pointer from getting in there in the first place. http://code.google.com/p/dart/issues/detail?id=2365 Committed: https://code.google.com/p/dart/source/detail?r=6140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
8 years, 8 months ago (2012-04-03 18:51:54 UTC) #1
scheglov
8 years, 8 months ago (2012-04-03 19:00:40 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698