Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 9959054: More error recovery back to the top level for some cases (Closed)

Created:
8 years, 8 months ago by zundel
Modified:
8 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, messick
Visibility:
Public.

Description

More error recovery back to the top level for some cases Committed: https://code.google.com/p/dart/source/detail?r=6113

Patch Set 1 : Added new unit test #

Total comments: 1

Patch Set 2 : Previous patch had problems when JUnit tests added #

Total comments: 3

Messages

Total messages: 6 (0 generated)
zundel
I added this recovery to help with code completion in cases where a file defines ...
8 years, 8 months ago (2012-04-01 21:10:51 UTC) #1
zundel
Also, I compared performance by running the 'dart stress test' and didn't see a difference ...
8 years, 8 months ago (2012-04-01 21:11:31 UTC) #2
messick
Nice. Thanks!
8 years, 8 months ago (2012-04-01 23:08:15 UTC) #3
scheglov
LGTM
8 years, 8 months ago (2012-04-02 16:04:33 UTC) #4
zundel
PTAL. I must have been testing without JUnit on because when I went to submit, ...
8 years, 8 months ago (2012-04-02 20:02:59 UTC) #5
scheglov
8 years, 8 months ago (2012-04-02 21:12:13 UTC) #6
LGTM

https://chromiumcodereview.appspot.com/9959054/diff/5002/compiler/java/com/go...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/9959054/diff/5002/compiler/java/com/go...
compiler/java/com/google/dart/compiler/parser/DartParser.java:345: } else if
(peekPseudoKeyword(0, INTERFACE_KEYWORD)
TYPEDEF_KEYWORD ?

Powered by Google App Engine
This is Rietveld 408576698