Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 9959048: Remove unused typed array factory constructors. (Closed)

Created:
8 years, 8 months ago by sra1
Modified:
8 years, 8 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, Jacob
Visibility:
Public.

Description

Remove unused typed array factory constructors. Remove unused typed array factory constructors in the class as the arrays are actually constructed in the factory constructor provider. Use native renaming to get rid of hand generated code for typed array 'setElements' method. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6072

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -233 lines) Patch
M client/tests/client/client.status View 1 2 chunks +5 lines, -2 lines 0 comments Download
A client/tests/client/dom/TypedArrays3Test.dart View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A client/tests/client/html/TypedArrays3Test.dart View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M lib/dom/frog/dom_frog.dart View 14 chunks +14 lines, -104 lines 0 comments Download
M lib/dom/scripts/generator.py View 1 chunk +5 lines, -18 lines 0 comments Download
M lib/dom/scripts/systemfrog.py View 4 chunks +6 lines, -20 lines 0 comments Download
M lib/dom/scripts/systemhtml.py View 2 chunks +2 lines, -5 lines 0 comments Download
M lib/html/frog/html_frog.dart View 14 chunks +12 lines, -84 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sra1
8 years, 8 months ago (2012-03-31 04:57:35 UTC) #1
tbr

Powered by Google App Engine
This is Rietveld 408576698