Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 9958091: Add missing type checks for top level static initializers (issue 1980 and (Closed)

Created:
8 years, 8 months ago by regis
Modified:
8 years, 8 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add missing type checks for top level static initializers (issue 1980 and duplicates 1957, 2070, 2224). Committed: https://code.google.com/p/dart/source/detail?r=6145

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -35 lines) Patch
M runtime/vm/code_generator_ia32.cc View 1 2 3 2 chunks +11 lines, -9 lines 0 comments Download
M runtime/vm/code_generator_x64.cc View 1 2 3 1 chunk +7 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 3 1 chunk +7 lines, -3 lines 0 comments Download
M runtime/vm/parser.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 2 3 9 chunks +27 lines, -12 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M tests/language/language.status View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
8 years, 8 months ago (2012-04-02 23:15:01 UTC) #1
regis
I have updated this cl to rethrow the exception raised by the initializer of a ...
8 years, 8 months ago (2012-04-03 17:39:28 UTC) #2
hausner
8 years, 8 months ago (2012-04-03 19:50:14 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698