Discard HTTP data written after a socket error

Discard HTTP data written after a socket error

If any type of HTTP connection encounters an error writing additional
data is an error. However in many cases getting exceptions from writes
in this situation is inconvenient.

With this change any data written will be silently discarded after an
error have occoured. The onError will always be called and the user of
the library have the ability to stop generating output data as soon as
possible.

Currently this is default behaviour with no option for changing it.

R=ajohnsen@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=6089

[Anders Johnsen, 2012-04-02 08:42:31]

LGTM, with comment.

https://chromiumcodereview.appspot.com/9958059/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9958059/diff/1/runtime/bin/http_impl.d...
runtime/bin/http_impl.dart:521: void _onClosed() {
Could the socket be closed normally from the client, when not all data have been
written? (E.g. the state where all current data is flushed, and the socket is
waiting for more data).

[Søren Gjesse, 2012-04-02 09:14:31]

https://chromiumcodereview.appspot.com/9958059/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9958059/diff/1/runtime/bin/http_impl.d...
runtime/bin/http_impl.dart:521: void _onClosed() {
On 2012/04/02 08:42:32, ajohnsen wrote:
> Could the socket be closed normally from the client, when not all data have
been
> written? (E.g. the state where all current data is flushed, and the socket is
> waiting for more data).

The client can half-close the socket when finished writing the request. That
will result in an onClosed event but the server can still write the full
response before closing the socket for writing.

However you have a point that the client can do a full close, and then writing
will fail. It should still go through onError though.

I will try to add a test.