Add support for Dromaeo tests in perf scripts.

Add support for Dromaeo tests in perf scripts.

Committed: https://code.google.com/p/dart/source/detail?r=6115

[Emily Fortuna, 2012-04-02 20:55:40]

lgtm

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/perf_t...
File tools/testing/perf_testing/run_perf_tests.py (right):

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/perf_t...
tools/testing/perf_testing/run_perf_tests.py:345: def
calculate_geometric_mean(self, platform, variants, svn_revision):
call this "variant"  since in this case it's not a list, just one item.

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/perf_t...
tools/testing/perf_testing/run_perf_tests.py:354: [math.pow(math.e, geo_mean /
len(self.values_list))]
values_list seems like the wrong item here.

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/perf_t...
tools/testing/perf_testing/run_perf_tests.py:669: '--compile-only',
os.path.join('..', 'samples', 'swarm',
If we use frogc, we don't need the "--compile-only" flag.

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/run_se...
File tools/testing/run_selenium.py (right):

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/run_se...
tools/testing/run_selenium.py:131: config = 'perf'
We could instead set a string to the value of the configuration instead of
having "action = 'store_true'" for the arguments, since only one config is valid
at a time, there's not much reason to have boolean flags for each one, and then
find a string afterward.

[Emily Fortuna, 2012-04-02 20:59:03]

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/perf_t...
File tools/testing/perf_testing/run_perf_tests.py (right):

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/perf_t...
tools/testing/perf_testing/run_perf_tests.py:354: [math.pow(math.e, geo_mean /
len(self.values_list))]
On 2012/04/02 20:55:40, Emily Fortuna wrote:
> values_list seems like the wrong item here.

Ignore this comment. I forgot to remove it.

[Emily Fortuna, 2012-04-02 21:10:10]

One more comment: When I tried to run the dromaeo tests on my computer I got a
file not found when it tried to direct the browser to that page. Is this because
I don't have the full dartium checkout?

[Emily Fortuna, 2012-04-02 21:27:41]

https://chromiumcodereview.appspot.com/9958051/diff/3001/samples/third_party/...
File samples/third_party/dromaeo/generate_frog_tests.py (right):

https://chromiumcodereview.appspot.com/9958051/diff/3001/samples/third_party/...
samples/third_party/dromaeo/generate_frog_tests.py:21: 'dart-sdk', 'bin',
'frogc'))
The reason I was getting a File not Found for these tests is this script fails
for me with this error: 
python generate_frog_tests.py 
Traceback (most recent call last):
  File "generate_frog_tests.py", line 64, in <module>
    HtmlConvert(test)
  File "generate_frog_tests.py", line 43, in HtmlConvert
    outfile = open(outfilename, 'w')
IOError: [Errno 2] No such file or directory: 'frog/dom-attr-dom-js.html'

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/perf_t...
File tools/testing/perf_testing/run_perf_tests.py (right):

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/perf_t...
tools/testing/perf_testing/run_perf_tests.py:579: run_cmd(['python',
os.path.join('generate_frog_tests.py')])
probably can get rid of os.path.join here.

[vsm, 2012-04-02 22:16:19]

Thanks, landing.

https://chromiumcodereview.appspot.com/9958051/diff/3001/samples/third_party/...
File samples/third_party/dromaeo/generate_frog_tests.py (right):

https://chromiumcodereview.appspot.com/9958051/diff/3001/samples/third_party/...
samples/third_party/dromaeo/generate_frog_tests.py:21: 'dart-sdk', 'bin',
'frogc'))
Thanks for the catch.  Added a makedirs if the path doesn't exist.

On 2012/04/02 21:27:41, Emily Fortuna wrote:
> The reason I was getting a File not Found for these tests is this script fails
> for me with this error: 
> python generate_frog_tests.py 
> Traceback (most recent call last):
>   File "generate_frog_tests.py", line 64, in <module>
>     HtmlConvert(test)
>   File "generate_frog_tests.py", line 43, in HtmlConvert
>     outfile = open(outfilename, 'w')
> IOError: [Errno 2] No such file or directory: 'frog/dom-attr-dom-js.html'

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/perf_t...
File tools/testing/perf_testing/run_perf_tests.py (right):

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/perf_t...
tools/testing/perf_testing/run_perf_tests.py:345: def
calculate_geometric_mean(self, platform, variants, svn_revision):
On 2012/04/02 20:55:40, Emily Fortuna wrote:
> call this "variant"  since in this case it's not a list, just one item.

Done.

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/perf_t...
tools/testing/perf_testing/run_perf_tests.py:579: run_cmd(['python',
os.path.join('generate_frog_tests.py')])
On 2012/04/02 21:27:41, Emily Fortuna wrote:
> probably can get rid of os.path.join here.

Done.

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/perf_t...
tools/testing/perf_testing/run_perf_tests.py:669: '--compile-only',
os.path.join('..', 'samples', 'swarm',
On 2012/04/02 20:55:40, Emily Fortuna wrote:
> If we use frogc, we don't need the "--compile-only" flag.

Done.

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/run_se...
File tools/testing/run_selenium.py (right):

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/run_se...
tools/testing/run_selenium.py:131: config = 'perf'
Agreed.  That would be cleaner.  I wasn't sure where else this script is being
invoked though.  Do you want me to change it?

On 2012/04/02 20:55:40, Emily Fortuna wrote:
> We could instead set a string to the value of the configuration instead of
> having "action = 'store_true'" for the arguments, since only one config is
valid
> at a time, there's not much reason to have boolean flags for each one, and
then
> find a string afterward.

[Emily Fortuna, 2012-04-02 22:19:08]

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/run_se...
File tools/testing/run_selenium.py (right):

https://chromiumcodereview.appspot.com/9958051/diff/3001/tools/testing/run_se...
tools/testing/run_selenium.py:131: config = 'perf'
On 2012/04/02 22:16:19, vsm wrote:
> Agreed.  That would be cleaner.  I wasn't sure where else this script is
being
> invoked though.  Do you want me to change it?
> 
> On 2012/04/02 20:55:40, Emily Fortuna wrote:
> > We could instead set a string to the value of the configuration instead of
> > having "action = 'store_true'" for the arguments, since only one config is
> valid
> > at a time, there's not much reason to have boolean flags for each one, and
> then
> > find a string afterward.
> 

I support changing it. Outside of the other script you changed, it's also being
invoked once by test.dart. That's it!