Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 9958049: Add some command line options to debug AST parsing of illegal dart (Closed)

Created:
8 years, 8 months ago by zundel
Modified:
8 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add some command line options to debug AST parsing of illegal dart There are 2 cmdline options added in this change 1. --source-from-ast reprints out the source by walking whatever AST was constructed from the parse. This helps visualize what the partially constructued AST looks like. 2. --resolve-on-parse-errors this option has been availble to API users, now it is exposed on the commandline. Used together, you can take dart source that doesn't parse and see how well the static analyzer understand it. Committed: https://code.google.com/p/dart/source/detail?r=6076

Patch Set 1 #

Patch Set 2 : Removed 'highlight unresolved', it didn't do much good #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -5 lines) Patch
M compiler/java/com/google/dart/compiler/CommandLineOptions.java View 3 chunks +20 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/DartCompiler.java View 1 3 chunks +20 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
8 years, 8 months ago (2012-04-01 00:50:09 UTC) #1
scheglov
8 years, 8 months ago (2012-04-01 02:30:33 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698