Issue 9958048: display line count in legpad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9958048: display line count in legpad (Closed)

Created:
8 years, 8 months ago by mattsh

Modified:
8 years, 8 months ago

Reviewers:
ahe, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

small fixes per code review BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6124

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	tools/testing/legpad/legpad.dart	View		1 chunk	+12 lines, -1 line	1 comment	Download
	M	tools/testing/legpad/legpad.py	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 8 months ago (2012-04-10 21:36:54 UTC) #3

LGTM

https://chromiumcodereview.appspot.com/9958048/diff/1/tools/testing/legpad/le...
File tools/testing/legpad/legpad.dart (right):

https://chromiumcodereview.appspot.com/9958048/diff/1/tools/testing/legpad/le...
tools/testing/legpad/legpad.dart:90: static int lineCount(String s) {
I feel this should be easier, but I don't know how :-(

Expand Messages | Collapse Messages