Issue 9958011: Building the Ssa graph has some sanity checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9958011: Building the Ssa graph has some sanity checks. (Closed)

Created:
8 years, 8 months ago by ngeoffray

Modified:
8 years, 8 months ago

Reviewers:
Lasse Reichstein Nielsen, floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Building the Ssa graph has some sanity checks. Committed: https://code.google.com/p/dart/source/detail?r=6028

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	dart/lib/compiler/implementation/native_handler.dart	View		4 chunks	+12 lines, -10 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

floitsch

8 years, 8 months ago (2012-03-30 19:41:26 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/9958011/diff/2001/dart/lib/compiler/im...
File dart/lib/compiler/implementation/native_handler.dart (right):

https://chromiumcodereview.appspot.com/9958011/diff/2001/dart/lib/compiler/im...
dart/lib/compiler/implementation/native_handler.dart:150: // we add a return
node to match the SSA builder expactations.
expectations

Expand Messages | Collapse Messages