Issue 9958007: During bailout construction add condition instructions to list of live variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9958007: During bailout construction add condition instructions to list of live variables. (Closed)

Created:
8 years, 8 months ago by floitsch

Modified:
8 years, 8 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

During bailout construction add condition instructions to list of live variables. Committed: https://code.google.com/p/dart/source/detail?r=6054

Patch Set 2 : Address comments. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -0 lines)			Patch
	M	lib/compiler/implementation/ssa/bailout.dart	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
	A	tests/language/src/ConditionBailoutTest.dart	View		1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/9958007/diff/1/lib/compiler/implementation/ssa/bailout.dart File lib/compiler/implementation/ssa/bailout.dart (right): https://chromiumcodereview.appspot.com/9958007/diff/1/lib/compiler/implementation/ssa/bailout.dart#newcode208 lib/compiler/implementation/ssa/bailout.dart:208: environment.add(instruction.condition); Maybe call visitInstruction instead? I know it ...

8 years, 8 months ago (2012-03-30 08:18:50 UTC) #2

floitsch

8 years, 8 months ago (2012-03-30 17:54:27 UTC) #3

https://chromiumcodereview.appspot.com/9958007/diff/1/lib/compiler/implementa...
File lib/compiler/implementation/ssa/bailout.dart (right):

https://chromiumcodereview.appspot.com/9958007/diff/1/lib/compiler/implementa...
lib/compiler/implementation/ssa/bailout.dart:208:
environment.add(instruction.condition);
On 2012/03/30 08:18:50, ngeoffray wrote:
> Maybe call visitInstruction instead? I know it ends up doing just this, but it
> may be safer to call it.

done. But be aware that this became visitInstruction(instruction) and not
visitInstruction(instruction.condition).

https://chromiumcodereview.appspot.com/9958007/diff/1/lib/compiler/implementa...
lib/compiler/implementation/ssa/bailout.dart:256:
environment.add(branch.condition);
On 2012/03/30 08:18:50, ngeoffray wrote:
> ditto

ditto (done, but visitInstruction(branch)).

Expand Messages | Collapse Messages

Issue 9958007: During bailout construction add condition instructions to list of live variables. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments. #

Messages