Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 9956152: Reapply "Refactor type propagation." (Closed)

Created:
8 years, 8 months ago by floitsch
Modified:
8 years, 8 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Refactor type propagation." This reapplies (a corrected version of ) commit 6599 which had been reverted in commit 6600. Original CL: https://chromiumcodereview.appspot.com//10098001 Committed: https://code.google.com/p/dart/source/detail?r=6601

Patch Set 1 #

Patch Set 2 : Apply fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -233 lines) Patch
M frog/tests/leg/leg.status View 1 chunk +2 lines, -0 lines 0 comments Download
A frog/tests/leg/src/TypeInference2Test.dart View 1 chunk +20 lines, -0 lines 0 comments Download
A frog/tests/leg/src/TypeInference3Test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M frog/tests/leg/src/TypeInferenceTest.dart View 1 1 chunk +1 line, -7 lines 0 comments Download
M lib/compiler/implementation/ssa/bailout.dart View 1 chunk +3 lines, -1 line 0 comments Download
M lib/compiler/implementation/ssa/nodes.dart View 33 chunks +312 lines, -185 lines 0 comments Download
M lib/compiler/implementation/ssa/optimize.dart View 8 chunks +21 lines, -14 lines 0 comments Download
M lib/compiler/implementation/ssa/tracer.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M lib/compiler/implementation/ssa/types.dart View 5 chunks +46 lines, -22 lines 0 comments Download
M tests/language/language-leg.status View 1 chunk +1 line, -2 lines 0 comments Download
A tests/language/src/ListDoubleIndexInLoop2Test.dart View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
Patchset 1 is the original (unfixed) CL. Patchset 2 applies the fix. Submitting TBR since ...
8 years, 8 months ago (2012-04-16 20:13:02 UTC) #1
floitsch
On 2012/04/16 20:13:02, floitsch wrote: > Patchset 1 is the original (unfixed) CL. > Patchset ...
8 years, 8 months ago (2012-04-16 20:13:14 UTC) #2
kasperl
8 years, 8 months ago (2012-04-17 05:32:51 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698