Issue 9956133: Remove many calls to Isolate::Current() in the dart embedding api by

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9956133: Remove many calls to Isolate::Current() in the dart embedding api by (Closed)

Created:
8 years, 8 months ago by turnidge

Modified:
8 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove many calls to Isolate::Current() in the dart embedding api by passing the isolate explicitly. Committed: https://code.google.com/p/dart/source/detail?r=6193

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+809 lines, -642 lines)			Patch
M	runtime/vm/dart_api_impl.h	View	1 2	3 chunks	+12 lines, -8 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2	118 chunks	+710 lines, -567 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2	16 chunks	+47 lines, -38 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	1 2	17 chunks	+19 lines, -19 lines	0 comments	Download
M	runtime/vm/native_entry.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2	2 chunks	+13 lines, -4 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2	1 chunk	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/unit_test.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM It might make sense to hold on to these changes until we can run ...

8 years, 8 months ago (2012-04-03 23:56:59 UTC) #2

turnidge

8 years, 8 months ago (2012-04-04 00:00:51 UTC) #3

Okay.  I will chill on this change for a bit so we can benchmark it.

https://chromiumcodereview.appspot.com/9956133/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://chromiumcodereview.appspot.com/9956133/diff/1/runtime/vm/object.h#new...
runtime/vm/object.h:51: static object& Handle(Isolate* islt) {                  
                    \
On 2012/04/03 23:56:59, asiva wrote:
> isolate instead of islt?

Done.  Also updated nearby instances of the same thing.

Expand Messages | Collapse Messages