Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 9956126: Fix for Issue 2399. (Closed)

Created:
8 years, 8 months ago by sra1
Modified:
8 years, 8 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, Anton Muhin
Visibility:
Public.

Description

Fix for Issue 2399 - broken []= on dartium dart:html typed arrays. Also fix buggy lastIndexOf and add test. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6153

Patch Set 1 #

Patch Set 2 : tests #

Patch Set 3 : supressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+967 lines, -833 lines) Patch
M client/tests/client/client.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M client/tests/client/client-leg.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A client/tests/client/dom/TypedArrays4Test.dart View 1 1 chunk +42 lines, -0 lines 0 comments Download
A client/tests/client/html/TypedArrays4Test.dart View 1 1 chunk +42 lines, -0 lines 0 comments Download
M lib/dom/frog/dom_frog.dart View 15 chunks +165 lines, -30 lines 0 comments Download
M lib/dom/scripts/systemhtml.py View 2 chunks +8 lines, -91 lines 0 comments Download
M lib/dom/templates/immutable_list_mixin.darttemplate View 1 chunk +11 lines, -2 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 29 chunks +541 lines, -682 lines 0 comments Download
M lib/html/frog/html_frog.dart View 14 chunks +154 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
8 years, 8 months ago (2012-04-03 23:02:06 UTC) #1
vsm
8 years, 8 months ago (2012-04-03 23:33:30 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698