Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 9956076: Make Storage implement Map. (Closed)

Created:
8 years, 8 months ago by nweiz
Modified:
8 years, 8 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org, sra1
Visibility:
Public.

Description

Make Storage implement Map. Committed: https://code.google.com/p/dart/source/detail?r=6117

Patch Set 1 #

Total comments: 4

Patch Set 2 : Marked underlying Storage methods as private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -38 lines) Patch
M client/tests/client/html/LocalStorageTests.dart View 1 chunk +96 lines, -10 lines 0 comments Download
M lib/dom/scripts/systemhtml.py View 1 1 chunk +6 lines, -0 lines 0 comments Download
A lib/dom/templates/html/impl/impl_Storage.darttemplate View 1 1 chunk +54 lines, -0 lines 0 comments Download
A lib/dom/templates/html/interface/interface_Storage.darttemplate View 1 1 chunk +7 lines, -0 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 2 chunks +64 lines, -14 lines 0 comments Download
M lib/html/frog/html_frog.dart View 1 2 chunks +64 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
Currently this has "$!MEMBERS" commented out in interface_Storage.darttemplate, which is ugly. But if I just ...
8 years, 8 months ago (2012-04-02 21:02:13 UTC) #1
Jacob
https://chromiumcodereview.appspot.com/9956076/diff/1/lib/dom/templates/html/impl/impl_Storage.darttemplate File lib/dom/templates/html/impl/impl_Storage.darttemplate (right): https://chromiumcodereview.appspot.com/9956076/diff/1/lib/dom/templates/html/impl/impl_Storage.darttemplate#newcode10 lib/dom/templates/html/impl/impl_Storage.darttemplate:10: bool containsKey(String key) => getItem(key) != null; you should ...
8 years, 8 months ago (2012-04-02 21:06:41 UTC) #2
nweiz
https://chromiumcodereview.appspot.com/9956076/diff/1/lib/dom/templates/html/impl/impl_Storage.darttemplate File lib/dom/templates/html/impl/impl_Storage.darttemplate (right): https://chromiumcodereview.appspot.com/9956076/diff/1/lib/dom/templates/html/impl/impl_Storage.darttemplate#newcode10 lib/dom/templates/html/impl/impl_Storage.darttemplate:10: bool containsKey(String key) => getItem(key) != null; On 2012/04/02 ...
8 years, 8 months ago (2012-04-02 22:32:14 UTC) #3
Jacob
8 years, 8 months ago (2012-04-02 22:41:47 UTC) #4
update
html/release/html.dart
with 
html/dartium/html_dartium.dart 
and you will be good to go

lgtm

Powered by Google App Engine
This is Rietveld 408576698