Expose a bug in the Http Header Parser.

Expose a bug in the Http Header Parser.
Committed: https://code.google.com/p/dart/source/detail?r=6083

[Søren Gjesse, 2012-04-02 07:36:02]

https://chromiumcodereview.appspot.com/9956058/diff/2001/tests/standalone/src...
File tests/standalone/src/io/HttpParserTest.dart (right):

https://chromiumcodereview.appspot.com/9956058/diff/2001/tests/standalone/src...
tests/standalone/src/io/HttpParserTest.dart:545:
_testParseInvalidRequest(request);
You should open a bug on this, and then wrap this in an Expect.throws so the
whole test can still run and wil fail when the bug is fixed. You could also
insert a TODO with the bug number.

https://chromiumcodereview.appspot.com/9956058/diff/2001/tests/standalone/sta...
File tests/standalone/standalone.status (right):

https://chromiumcodereview.appspot.com/9956058/diff/2001/tests/standalone/sta...
tests/standalone/standalone.status:21: io/HttpParserTest: Fail  # Currently
fails.
It would be better to open a bug on this instead of making the whole test fail.

[Anders Johnsen, 2012-04-02 08:19:01]

Updated, created bug: http://code.google.com/p/dart/issues/detail?id=2370

https://chromiumcodereview.appspot.com/9956058/diff/2001/tests/standalone/src...
File tests/standalone/src/io/HttpParserTest.dart (right):

https://chromiumcodereview.appspot.com/9956058/diff/2001/tests/standalone/src...
tests/standalone/src/io/HttpParserTest.dart:545:
_testParseInvalidRequest(request);
On 2012/04/02 07:36:02, Søren Gjesse wrote:
> You should open a bug on this, and then wrap this in an Expect.throws so the
> whole test can still run and wil fail when the bug is fixed. You could also
> insert a TODO with the bug number.

Done.

https://chromiumcodereview.appspot.com/9956058/diff/2001/tests/standalone/sta...
File tests/standalone/standalone.status (right):

https://chromiumcodereview.appspot.com/9956058/diff/2001/tests/standalone/sta...
tests/standalone/standalone.status:21: io/HttpParserTest: Fail  # Currently
fails.
On 2012/04/02 07:36:02, Søren Gjesse wrote:
> It would be better to open a bug on this instead of making the whole test
fail.

Aye, removed.

[Søren Gjesse, 2012-04-02 08:23:46]

lgtm

https://chromiumcodereview.appspot.com/9956058/diff/1004/tests/standalone/src...
File tests/standalone/src/io/HttpParserTest.dart (right):

https://chromiumcodereview.appspot.com/9956058/diff/1004/tests/standalone/src...
tests/standalone/src/io/HttpParserTest.dart:545: // Issue #2370
We normally format like this:

// TODO(2370): HTTP parser error.

[Anders Johnsen, 2012-04-02 08:25:44]

Committing.

https://chromiumcodereview.appspot.com/9956058/diff/1004/tests/standalone/src...
File tests/standalone/src/io/HttpParserTest.dart (right):

https://chromiumcodereview.appspot.com/9956058/diff/1004/tests/standalone/src...
tests/standalone/src/io/HttpParserTest.dart:545: // Issue #2370
On 2012/04/02 08:23:46, Søren Gjesse wrote:
> We normally format like this:
> 
> // TODO(2370): HTTP parser error.

Ah, right, thank you!