Issue 9956037: Simplify tests under utils/tests to follow StandardTestSuite convention.

Issue 9956037: Simplify tests under utils/tests to follow StandardTestSuite convention. (Closed)

Created:
8 years, 8 months ago by Bob Nystrom

Modified:
8 years, 8 months ago

Reviewers:
Siggi Cherem (dart-lang), Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Simplify tests under utils/tests to follow StandardTestSuite convention. Committed: https://code.google.com/p/dart/source/detail?r=6209

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -1497 lines)			Patch
M	tools/test.dart	View	3 chunks	+3 lines, -12 lines	1 comment	Download
A +	utils/tests/css/declaration_tests.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	utils/tests/css/expression_tests.dart	View	7 chunks	+7 lines, -7 lines	0 comments	Download
A +	utils/tests/css/selector_literal_tests.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
D	utils/tests/css/src/DeclarationTest.dart	View	1 chunk	+0 lines, -255 lines	0 comments	Download
D	utils/tests/css/src/ExpressionTest.dart	View	1 chunk	+0 lines, -532 lines	0 comments	Download
D	utils/tests/css/src/SelectorLiteralTest.dart	View	1 chunk	+0 lines, -241 lines	0 comments	Download
D	utils/tests/css/test_config.dart	View	1 chunk	+0 lines, -15 lines	0 comments	Download
A +	utils/tests/import_mapper/a.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	utils/tests/import_mapper/b.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	utils/tests/import_mapper/c.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	utils/tests/import_mapper/import_mapper_tests.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
D	utils/tests/import_mapper/src/a.dart	View	1 chunk	+0 lines, -10 lines	0 comments	Download
D	utils/tests/import_mapper/src/b.dart	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	utils/tests/import_mapper/src/c.dart	View	1 chunk	+0 lines, -10 lines	0 comments	Download
D	utils/tests/import_mapper/src/import_mapper_tests.dart	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	utils/tests/import_mapper/test_config.dart	View	1 chunk	+0 lines, -17 lines	0 comments	Download
A +	utils/tests/peg/peg_tests.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	utils/tests/peg/src/PegTest.dart	View	1 chunk	+0 lines, -346 lines	0 comments	Download
D	utils/tests/peg/test_config.dart	View	1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

This patch isn't as huge as it looks. I moved files out of "src" directories, ...

8 years, 8 months ago (2012-03-30 21:58:39 UTC) #1

Emily Fortuna

8 years, 8 months ago (2012-04-02 20:44:15 UTC) #3

lgtm

https://chromiumcodereview.appspot.com/9956037/diff/1/tools/test.dart
File tools/test.dart (right):

https://chromiumcodereview.appspot.com/9956037/diff/1/tools/test.dart#newcode58
tools/test.dart:58: 'utils/tests/peg',
I'd cc someone in AAR on this CL just so they're aware that peg is changing
slightly.

Expand Messages | Collapse Messages