Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Issue 9956012: Don't use === instead of equality-method call for user class constants. (Closed)

Created:
8 years, 8 months ago by floitsch
Modified:
8 years, 8 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't use === instead of equality-method call for user class constants. Committed: https://code.google.com/p/dart/source/detail?r=6048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M lib/compiler/implementation/ssa/nodes.dart View 1 chunk +6 lines, -1 line 0 comments Download
A tests/language/src/CompileTimeConstantNTest.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
floitsch
8 years, 8 months ago (2012-03-30 05:22:29 UTC) #1
ngeoffray
8 years, 8 months ago (2012-03-30 08:33:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698