Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 9950092: SystemLibraryManager normalized URI test (Closed)

Created:
8 years, 8 months ago by danrubel
Modified:
8 years, 8 months ago
Reviewers:
zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

SystemLibraryManager config update Committed: https://code.google.com/p/dart/source/detail?r=6152

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M lib/config/import_any.config View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danrubel
8 years, 8 months ago (2012-04-03 14:01:08 UTC) #1
zundel
(see the diff I sent as a separate message) https://chromiumcodereview.appspot.com/9950092/diff/1/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java File editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java (right): https://chromiumcodereview.appspot.com/9950092/diff/1/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java#newcode99 editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java:99: ...
8 years, 8 months ago (2012-04-03 14:32:37 UTC) #2
danrubel
https://chromiumcodereview.appspot.com/9950092/diff/1/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java File editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java (right): https://chromiumcodereview.appspot.com/9950092/diff/1/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java#newcode99 editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java:99: // TODO (danrubel) move this test into the analysis ...
8 years, 8 months ago (2012-04-03 23:17:04 UTC) #3
zundel
8 years, 8 months ago (2012-04-03 23:26:44 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698