Implements error recovery for cases where 'var' or 'final' prefix a method def'n

Implements error recovery for cases where 'var' or 'final' prefix a method def'n

These are common user mistakes, it prints a reasonable diagnostic
as opposed to 'unexpected token'.

Committed: https://code.google.com/p/dart/source/detail?r=6078

[zundel, 2012-04-01 03:21:24]

I'm hoping to implement a few error recovery cases
in the existing parser while we are waiting for our 
new parser to come online.

[scheglov, 2012-04-01 04:37:10]

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/java/com/go...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/java/com/go...
compiler/java/com/google/dart/compiler/parser/DartParser.java:166: public static
final ImmutableSet<String> allPseudoKeywords =
ImmutableSet.copyOf(PSEUDO_KEYWORDS);
Can we make this PSEUDO_KEYWORD_SET ?

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/java/com/go...
File compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java (right):

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/java/com/go...
compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java:59:
FINAL_IS_NOT_ALLOWED_ON_A_METHOD_DEFINITION("'final' is not allowed on method
definitions."),
Not with my English to say this, but for consistency 'a' should be used or not
used in both places.

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/java/com/go...
compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java:89:
VAR_IS_NOT_ALLOWED_ON_A_METHOD_DEFINITION("'var' is not allowed on a method
definition"),
In FINAL_IS_NOT_ALLOWED_ON_A_METHOD_DEFINITION we used "definitions", not sure
which form is better

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/javatests/c...
File compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java (right):

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/javatests/c...
compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java:343: "  f3()
{ return 2; }",
It does not look that we cover all new code here.
At least case of method with return type is not covered.

Not sure about different variants in looksLikeMethodOrAccessorDefinition().

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/javatests/c...
compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java:357: public
void testfinalOnFunction() {
"testFinalOnFunction" ?

[zundel, 2012-04-01 12:51:14]

PTAL

I added a separate test for using pseudokeywords as a method or field name.
There were test cases for these in the set of shared tests which is why
everything "works", but its better to have a JUnit test to make sure we are
getting them into
the correct AST form.

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/java/com/go...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/java/com/go...
compiler/java/com/google/dart/compiler/parser/DartParser.java:166: public static
final ImmutableSet<String> allPseudoKeywords =
ImmutableSet.copyOf(PSEUDO_KEYWORDS);
On 2012/04/01 04:37:11, scheglov wrote:
> Can we make this PSEUDO_KEYWORD_SET ?

Done.

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/java/com/go...
File compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java (right):

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/java/com/go...
compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java:59:
FINAL_IS_NOT_ALLOWED_ON_A_METHOD_DEFINITION("'final' is not allowed on method
definitions."),
On 2012/04/01 04:37:11, scheglov wrote:
> Not with my English to say this, but for consistency 'a' should be used or not
> used in both places.

The English message was grammatically correct because I had 'definitions' set to
plural, but not consistent with the enum name.  (I got rid of the plural)

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/java/com/go...
compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java:89:
VAR_IS_NOT_ALLOWED_ON_A_METHOD_DEFINITION("'var' is not allowed on a method
definition"),
On 2012/04/01 04:37:11, scheglov wrote:
> In FINAL_IS_NOT_ALLOWED_ON_A_METHOD_DEFINITION we used "definitions", not sure
> which form is better

I settled on singular form to make it consistent.
Done.

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/javatests/c...
File compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java (right):

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/javatests/c...
compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java:343: "  f3()
{ return 2; }",
On 2012/04/01 04:37:11, scheglov wrote:
> It does not look that we cover all new code here.
> At least case of method with return type is not covered.
> 
> Not sure about different variants in looksLikeMethodOrAccessorDefinition().

Done.

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/javatests/c...
compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java:357: public
void testfinalOnFunction() {
On 2012/04/01 04:37:11, scheglov wrote:
> "testFinalOnFunction" ?

Done.

[zundel, 2012-04-01 12:59:51]

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/java/com/go...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/9950045/diff/1008/compiler/java/com/go...
compiler/java/com/google/dart/compiler/parser/DartParser.java:166: public static
final ImmutableSet<String> allPseudoKeywords =
ImmutableSet.copyOf(PSEUDO_KEYWORDS);
On 2012/04/01 12:51:15, zundel wrote:
> On 2012/04/01 04:37:11, scheglov wrote:
> > Can we make this PSEUDO_KEYWORD_SET ?

Turns out I wasn't using it anyway.  Deleted.

[scheglov, 2012-04-01 16:50:41]

LGTM