Renamed the 'dartc' launch script to 'dart-analysis' and adds it to dart-sdk

Renamed the 'dartc' launch script to 'dart_analyzer' and adds it to dart-sdk

Some now unused scripts and files were also removed.

Committed: https://code.google.com/p/dart/source/detail?r=8373

Committed: https://code.google.com/p/dart/source/detail?r=8392

[scheglov, 2012-03-30 17:28:17]

LGTM

[zundel, 2012-03-30 18:47:28]

@Dan:  Here's what the dart-sdk directory structure looks like after you build
the distro:

$ ls -R util
util:
analysis

util/analysis:
args4j	dart-analysis.jar  guava  json

util/analysis/args4j:
2.0.12

util/analysis/args4j/2.0.12:
args4j-2.0.12.jar

util/analysis/guava:
r09

util/analysis/guava/r09:
guava-r09.jar

util/analysis/json:
r2_20080312

util/analysis/json/r2_20080312:
json.jar


$ ls -R bin
bin:
dart  dart-analysis  frogc  frogc.dart

[dgrove, 2012-03-30 21:40:11]

lgtm

LGTM once *analysis* -> *analyzer*

https://chromiumcodereview.appspot.com/9950019/diff/22/tools/create_sdk.py
File tools/create_sdk.py (right):

https://chromiumcodereview.appspot.com/9950019/diff/22/tools/create_sdk.py#ne...
tools/create_sdk.py:19: # ......dart-analysis
Thinking about this more, I think this should be dart_analyzer. dart-analysis
seems like a step in a process, rather than a thing. We also don't have any
hyphens within the SDK.  If we do this, the directory and files in util need to
become *analyzer*, as well.

[zundel, 2012-04-05 09:14:13]

On 2012/03/30 21:40:11, dgrove wrote:
> lgtm
> 
> LGTM once *analysis* -> *analyzer*
> 
> https://chromiumcodereview.appspot.com/9950019/diff/22/tools/create_sdk.py
> File tools/create_sdk.py (right):
> 
>
https://chromiumcodereview.appspot.com/9950019/diff/22/tools/create_sdk.py#ne...
> tools/create_sdk.py:19: # ......dart-analysis
> Thinking about this more, I think this should be dart_analyzer. dart-analysis
> seems like a step in a process, rather than a thing. We also don't have any
> hyphens within the SDK.  If we do this, the directory and files in util need
to
> become *analyzer*, as well.

This path is still outstanding because when I went to commit this last time, one
of the editor builds mysteriously failed and I had to revert it.

*and* Kasper had some feedback on prefering - vs. _

[scheglov, 2012-04-05 13:09:51]

LGTM

http://codereview.chromium.org/9950019/diff/1022/compiler/dart-compiler.gyp
File compiler/dart-compiler.gyp (right):

http://codereview.chromium.org/9950019/diff/1022/compiler/dart-compiler.gyp#n...
compiler/dart-compiler.gyp:55: 'outputs': [
'<(PRODUCT_DIR)/analyzer/dart_analyzer-tests.jar' ],
"-tests"
I'm not not sure if we want to change this too, just bringing it to your
attention.

http://codereview.chromium.org/9950019/diff/1022/compiler/scripts/analyzer_me...
File compiler/scripts/analyzer_metrics.sh (right):

http://codereview.chromium.org/9950019/diff/1022/compiler/scripts/analyzer_me...
compiler/scripts/analyzer_metrics.sh:73: if [ "" = "$ANALYZER" ] || [ ! -x
$ANALYXER ]; then
analyXer ?

http://codereview.chromium.org/9950019/diff/1022/compiler/scripts/analyzer_se...
File compiler/scripts/analyzer_series_test.sh (right):

http://codereview.chromium.org/9950019/diff/1022/compiler/scripts/analyzer_se...
compiler/scripts/analyzer_series_test.sh:204: $SCRIPT_PATH/dart_analyzer.sh
--stats-prefix=$REVISION --analyzer=$PREBUILT_DIR/analyzer/bin/dart_analzyer
$COMPARE_OPTIONS > $STAT1
anaLZYer

http://codereview.chromium.org/9950019/diff/1022/compiler/scripts/dart_analyz...
File compiler/scripts/dart_analyzer.sh (right):

http://codereview.chromium.org/9950019/diff/1022/compiler/scripts/dart_analyz...
compiler/scripts/dart_analyzer.sh:33: DEV_SDKDIR=$(dirname
$DART_ANALYZER_HOME)/dart-sdk
DEV_SDK_DIR ?

[zundel, 2012-04-11 10:21:54]

This is ready to go pending a fixup of the GYP config that Peter has been
working on.

http://codereview.chromium.org/9950019/diff/1022/compiler/dart-compiler.gyp
File compiler/dart-compiler.gyp (right):

http://codereview.chromium.org/9950019/diff/1022/compiler/dart-compiler.gyp#n...
compiler/dart-compiler.gyp:55: 'outputs': [
'<(PRODUCT_DIR)/analyzer/dart_analyzer-tests.jar' ],
On 2012/04/05 13:09:51, scheglov wrote:
> "-tests"
> I'm not not sure if we want to change this too, just bringing it to your
> attention.

Done.

http://codereview.chromium.org/9950019/diff/1022/compiler/scripts/analyzer_me...
File compiler/scripts/analyzer_metrics.sh (right):

http://codereview.chromium.org/9950019/diff/1022/compiler/scripts/analyzer_me...
compiler/scripts/analyzer_metrics.sh:73: if [ "" = "$ANALYZER" ] || [ ! -x
$ANALYXER ]; then
On 2012/04/05 13:09:51, scheglov wrote:
> analyXer ?

Done.

http://codereview.chromium.org/9950019/diff/1022/compiler/scripts/dart_analyz...
File compiler/scripts/dart_analyzer.sh (right):

http://codereview.chromium.org/9950019/diff/1022/compiler/scripts/dart_analyz...
compiler/scripts/dart_analyzer.sh:33: DEV_SDKDIR=$(dirname
$DART_ANALYZER_HOME)/dart-sdk
On 2012/04/05 13:09:51, scheglov wrote:
> DEV_SDK_DIR ?

Done.

[scheglov, 2012-04-11 19:51:59]

LGTM

http://codereview.chromium.org/9950019/diff/11001/compiler/dart_analyzer.xml
File compiler/dart_analyzer.xml (right):

http://codereview.chromium.org/9950019/diff/11001/compiler/dart_analyzer.xml#...
compiler/dart_analyzer.xml:154: <chmod file="${build.dir}/anlaysis_metrics.sh"
perm="a+rx"/>
May be also "analyzer"?
And BTW right now it is misspelled.

http://codereview.chromium.org/9950019/diff/11001/compiler/dart_analyzer.xml#...
compiler/dart_analyzer.xml:157: Copy of all of the dart anaysis dependencies to
the library folder.
analyzer ?
misspelled

http://codereview.chromium.org/9950019/diff/11001/compiler/scripts/analyzer_s...
File compiler/scripts/analyzer_series_test.sh (right):

http://codereview.chromium.org/9950019/diff/11001/compiler/scripts/analyzer_s...
compiler/scripts/analyzer_series_test.sh:204: $SCRIPT_PATH/dart_analyzer.sh
--stats-prefix=$REVISION --analyzer=$PREBUILT_DIR/analyzer/bin/dart_analzyer
$COMPARE_OPTIONS > $STAT1
analzyer -> analyzer

http://codereview.chromium.org/9950019/diff/11001/dart.gyp
File dart.gyp (right):

http://codereview.chromium.org/9950019/diff/11001/dart.gyp#newcode13
dart.gyp:13: 'target_name': 'compiler',
Still something about "compiler"?
Is this dart2js or something left from DartC?

[zundel, 2012-04-17 10:00:41]

Addressed comments.

This is still blocked waiting for Peter's fix to gyp build system for windows
builds.

http://codereview.chromium.org/9950019/diff/11001/compiler/dart_analyzer.xml
File compiler/dart_analyzer.xml (right):

http://codereview.chromium.org/9950019/diff/11001/compiler/dart_analyzer.xml#...
compiler/dart_analyzer.xml:154: <chmod file="${build.dir}/anlaysis_metrics.sh"
perm="a+rx"/>
On 2012/04/11 19:51:59, scheglov wrote:
> May be also "analyzer"?
> And BTW right now it is misspelled.

Done.

http://codereview.chromium.org/9950019/diff/11001/compiler/dart_analyzer.xml#...
compiler/dart_analyzer.xml:157: Copy of all of the dart anaysis dependencies to
the library folder.
On 2012/04/11 19:51:59, scheglov wrote:
> analyzer ?
> misspelled

Done.

http://codereview.chromium.org/9950019/diff/11001/compiler/scripts/analyzer_s...
File compiler/scripts/analyzer_series_test.sh (right):

http://codereview.chromium.org/9950019/diff/11001/compiler/scripts/analyzer_s...
compiler/scripts/analyzer_series_test.sh:204: $SCRIPT_PATH/dart_analyzer.sh
--stats-prefix=$REVISION --analyzer=$PREBUILT_DIR/analyzer/bin/dart_analzyer
$COMPARE_OPTIONS > $STAT1
On 2012/04/11 19:51:59, scheglov wrote:
> analzyer -> analyzer

Done.

http://codereview.chromium.org/9950019/diff/11001/dart.gyp
File dart.gyp (right):

http://codereview.chromium.org/9950019/diff/11001/dart.gyp#newcode13
dart.gyp:13: 'target_name': 'compiler',
On 2012/04/11 19:51:59, scheglov wrote:
> Still something about "compiler"?
> Is this dart2js or something left from DartC?

This target might be invoked from a script outside,
(like the buildbots) so I didn't want to change it in this
CL

[ahe, 2012-04-17 12:11:56]

On 2012/04/17 10:00:41, zundel wrote:
> This is still blocked waiting for Peter's fix to gyp build system for windows
> builds.

The gyp files have been fixed.

Cheers,
Peter

[zundel, 2012-04-17 13:23:46]

Once getting past the problem Peter fixed, the dart_analyzer build still gets
into trouble early on:

20>------ Build started: Project: dart_analyzer, Configuration: Release_ia32
Win32 ------
20>Building dart_analyzer.
20>bash: ../third_party/apache_ant/v1_7_1/bin/ant: /bin/sh: bad interpreter: No
such file or directory
20>Project : error PRJ0019: A tool returned an error code from "Building
dart_analyzer."
20>Build log was saved at
"file://e:\b\build\slave\dart-editor-win\build\dart\compiler\Release_ia32\obj\dart_analyzer\BuildLog.htm"
20>dart_analyzer - 1 error(s), 0 warning(s)

I am reverting the change again.

[ahe, 2012-04-17 14:37:18]

On 2012/04/17 13:23:46, zundel wrote:
> Once getting past the problem Peter fixed, the dart_analyzer build still gets
> into trouble early on:
> 
> 20>------ Build started: Project: dart_analyzer, Configuration: Release_ia32
> Win32 ------
> 20>Building dart_analyzer.
> 20>bash: ../third_party/apache_ant/v1_7_1/bin/ant: /bin/sh: bad interpreter:
No
> such file or directory
> 20>Project : error PRJ0019: A tool returned an error code from "Building
> dart_analyzer."
> 20>Build log was saved at
>
"file://e:\b\build\slave\dart-editor-win\build\dart\compiler\Release_ia32\obj\dart_analyzer\BuildLog.htm"
> 20>dart_analyzer - 1 error(s), 0 warning(s)
> 
> I am reverting the change again.

I think you need to use the ant.bat file on windows. Let me know if you need
help with the GYP incantations.

[Bill Hesse, 2012-06-12 12:19:46]

A request for a fix on test_suite.dart

https://chromiumcodereview.appspot.com/9950019/diff/29003/tools/testing/dart/...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9950019/diff/29003/tools/testing/dart/...
tools/testing/dart/test_suite.dart:389: testName.endsWith('_test.dart')) {
I looked at this a couple of weeks ago, and came to the conclusion that there
were no tests run with dart_analyzer that did not end in _test.dart, so this
guard could be removed.  It would be great, and really simplify things, if it
could be.

If there are any tests that still hit this guard, couldn't we update their
status file entries to not use .dart?

Let's get rid of this (and I will then be able to use the new Path library
better in the enclosing code).