Issue 9939003: Use null type argument vector instead of vector of Dynamic for a generic raw

Issue 9939003: Use null type argument vector instead of vector of Dynamic for a generic raw (Closed)

Created:
8 years, 8 months ago by regis

Modified:
8 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use null type argument vector instead of vector of Dynamic for a generic raw type when possible. Fix type finalization of type parameters (always finalize in the context of the class being parameterized and not in the enclosing class where the type parameter is used). Fix wrong generic optimization and added a test (a generic type instantiated from a raw instantiator is not always raw). Added printing of type argument vectors. Committed: https://code.google.com/p/dart/source/detail?r=6068

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Patch Set 6 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+515 lines, -260 lines)			Patch
M	runtime/vm/class_finalizer.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1 2 3 4 5	9 chunks	+90 lines, -44 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2 3 4 5	6 chunks	+33 lines, -50 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1 2 3 4 5	8 chunks	+22 lines, -15 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1 2 3 4 5	8 chunks	+26 lines, -16 lines	0 comments	Download
M	runtime/vm/dart_api_message.cc	View	1 2 3 4 5	3 chunks	+20 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3 4 5	7 chunks	+60 lines, -49 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4 5	8 chunks	+43 lines, -6 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4 5	18 chunks	+130 lines, -53 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3 4 5	2 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2 3 4 5	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code.h	View	1 2 3 4 5	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3 4 5	3 chunks	+7 lines, -8 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2 3 4 5	3 chunks	+7 lines, -8 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language-leg.status	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/src/GenericInstanceof2Test.dart	View		1 chunk	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

Hi Srdjan, Sorry for the large change list, but the fixed issues depend on each ...

8 years, 8 months ago (2012-03-29 23:55:53 UTC) #1

srdjan

LGTM https://chromiumcodereview.appspot.com/9939003/diff/9001/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://chromiumcodereview.appspot.com/9939003/diff/9001/runtime/vm/class_finalizer.cc#newcode484 runtime/vm/class_finalizer.cc:484: intptr_t num_types = type_parameters.Length(); const https://chromiumcodereview.appspot.com/9939003/diff/16024/runtime/vm/dart_api_message.cc File runtime/vm/dart_api_message.cc ...

8 years, 8 months ago (2012-03-30 21:46:52 UTC) #3

regis

8 years, 8 months ago (2012-03-30 22:01:43 UTC) #4

Thanks a lot!

https://chromiumcodereview.appspot.com/9939003/diff/9001/runtime/vm/class_fin...
File runtime/vm/class_finalizer.cc (right):

https://chromiumcodereview.appspot.com/9939003/diff/9001/runtime/vm/class_fin...
runtime/vm/class_finalizer.cc:484: intptr_t num_types =
type_parameters.Length();
On 2012/03/30 21:46:52, srdjan wrote:
> const

Done.

https://chromiumcodereview.appspot.com/9939003/diff/16024/runtime/vm/dart_api...
File runtime/vm/dart_api_message.cc (right):

https://chromiumcodereview.appspot.com/9939003/diff/16024/runtime/vm/dart_api...
runtime/vm/dart_api_message.cc:198: // TODO(sjesse): Fix this workaround
ignoring the type parameter.
On 2012/03/30 21:46:52, srdjan wrote:
> sgjesse

Done. But many others are spelled "sjesse".

Expand Messages | Collapse Messages