Issue 9918014: Fix issue http://dartbug.com/2342 by checking document.readyState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9918014: Fix issue http://dartbug.com/2342 by checking document.readyState (Closed)

Created:
8 years, 8 months ago by kasperl

Modified:
8 years, 8 months ago

Reviewers:
vsm, sethladd

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue http://dartbug.com/2342 by checking document.readyState before adding the DOMContentLoaded event listening. Committed: https://code.google.com/p/dart/source/detail?r=5984

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -5 lines)			Patch
M	frog/gen.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	frog/minfrog	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/emitter.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 8 months ago (2012-03-29 17:02:40 UTC) #2

LGTM

I have not been able to find anything in the spec that clarifies that
document.readyState is changed away from "loading" before DOMContentLoaded is
fired.  It does appear to be the behavior today, however.  (I just tested
locally on FF/Safari/Chrome on Mac and FF/Chrome on Linux.)

Expand Messages | Collapse Messages