Issue 9916001: Fix LocalFunctionTest and update status files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9916001: Fix LocalFunctionTest and update status files. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 8 months ago

Reviewers:
ahe, gbracha, siva

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix LocalFunctionTest and update status files. Committed: https://code.google.com/p/dart/source/detail?r=5964

Patch Set 1 #

Total comments: 3

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -2 lines)			Patch
M	tests/language/language.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language-leg.status	View	1 chunk	+1 line, -1 line	1 comment	Download
M	tests/language/src/LocalFunctionTest.dart	View	3 chunks	+22 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://chromiumcodereview.appspot.com/9916001/diff/1/tests/language/language-leg.status File tests/language/language-leg.status (right): https://chromiumcodereview.appspot.com/9916001/diff/1/tests/language/language-leg.status#newcode40 tests/language/language-leg.status:40: LocalFunctionTest: Fail # TypeError: Object #<Closure> has no ...

8 years, 8 months ago (2012-03-29 05:26:38 UTC) #3

ahe

8 years, 8 months ago (2012-03-29 06:59:47 UTC) #4

Florian's changes are fine, however, I think the test is still broken.

https://chromiumcodereview.appspot.com/9916001/diff/1/tests/language/src/Loca...
File tests/language/src/LocalFunctionTest.dart (right):

https://chromiumcodereview.appspot.com/9916001/diff/1/tests/language/src/Loca...
tests/language/src/LocalFunctionTest.dart:145: } catch
(ClosureArgumentMismatchException e) {
This exception is not specified in the language specification. I think this
exception and ObjectNotClosure adds little value and only complicates
implementation and specification.

We need to get rid of all these weird exceptions and use only
NoSuchMethodException.

As far as I'm concerned, WrongArgumentCountException, ObjectNotClosure,
StaticResolutionException, and ClosureArgumentMismatchException do not belong in
Dart.

https://chromiumcodereview.appspot.com/9916001/diff/1/tests/language/src/Loca...
tests/language/src/LocalFunctionTest.dart:152: } catch
(ClosureArgumentMismatchException e) {
Ditto.

Expand Messages | Collapse Messages