Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 9911018: Fix path previously only intended for Windows. (Now runs also if the out directory doesn't exist). (Closed)

Created:
8 years, 8 months ago by Emily Fortuna
Modified:
8 years, 8 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix path previously only intended for Windows. (Now runs also if the out directory doesn't exist). Committed: https://code.google.com/p/dart/source/detail?r=5997

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M tools/testing/perf_testing/run_perf_tests.py View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Emily Fortuna
8 years, 8 months ago (2012-03-29 18:36:13 UTC) #1
vsm
8 years, 8 months ago (2012-03-29 18:37:03 UTC) #2
lgtm

https://chromiumcodereview.appspot.com/9911018/diff/1/tools/testing/perf_test...
File tools/testing/perf_testing/run_perf_tests.py (right):

https://chromiumcodereview.appspot.com/9911018/diff/1/tools/testing/perf_test...
tools/testing/perf_testing/run_perf_tests.py:21: import sys
Nit: sys before time for alpha order.

Powered by Google App Engine
This is Rietveld 408576698