Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 9909024: Fix trigonometric intrinsics: if allocation fails remember to release the loaded value on FPU stack. (Closed)

Created:
8 years, 8 months ago by srdjan
Modified:
8 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix trigonometric intrinsics: if allocation fails remember to release the loaded value on FPU stack. Committed: https://code.google.com/p/dart/source/detail?r=6003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M runtime/vm/assembler_ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/assembler_ia32_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
Fixes issue 2347
8 years, 8 months ago (2012-03-29 20:19:22 UTC) #1
regis
8 years, 8 months ago (2012-03-29 20:34:20 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698