Issue 9909012: Prevent duplicate entries in the bundled libraries

Issue 9909012: Prevent duplicate entries in the bundled libraries (Closed)

Created:
8 years, 8 months ago by danrubel

Modified:
8 years, 8 months ago

Reviewers:
zundel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Prevent duplicate entries in the bundled libraries Committed: https://code.google.com/p/dart/source/detail?r=5999

Patch Set 3 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -17 lines)			Patch
M	compiler/java/com/google/dart/compiler/SystemLibraryManager.java	View	1 2	1 chunk	+10 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java	View		2 chunks	+16 lines, -0 lines	0 comments	Download
M	lib/config/import_any.config	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	lib/config/import_dart2js.config	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	lib/config/import_dartium.config	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	lib/config/import_frog.config	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	lib/config/import_vm.config	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zundel

https://chromiumcodereview.appspot.com/9909012/diff/2001/compiler/java/com/google/dart/compiler/SystemLibraryManager.java File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right): https://chromiumcodereview.appspot.com/9909012/diff/2001/compiler/java/com/google/dart/compiler/SystemLibraryManager.java#newcode201 compiler/java/com/google/dart/compiler/SystemLibraryManager.java:201: HashMap<URI, SystemLibrary> shortUriToLibraryMap = new HashMap<URI, SystemLibrary>(); This map ...

8 years, 8 months ago (2012-03-29 15:17:36 UTC) #2

danrubel

Reworked code to use hostMap. PTAL https://chromiumcodereview.appspot.com/9909012/diff/2001/compiler/java/com/google/dart/compiler/SystemLibraryManager.java File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right): https://chromiumcodereview.appspot.com/9909012/diff/2001/compiler/java/com/google/dart/compiler/SystemLibraryManager.java#newcode201 compiler/java/com/google/dart/compiler/SystemLibraryManager.java:201: HashMap<URI, SystemLibrary> shortUriToLibraryMap ...

8 years, 8 months ago (2012-03-29 17:00:57 UTC) #3

lgtm

Expand Messages | Collapse Messages