Issue 9909011: Implement redirecting natives.

Issue 9909011: Implement redirecting natives. (Closed)

Created:
8 years, 8 months ago by ngeoffray

Modified:
8 years, 8 months ago

Reviewers:
floitsch, kasperl, sra1

CC:
reviews_dartlang.org, floitsch, karlklose, ahe, Lasse Reichstein Nielsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Implement redirecting natives. Committed: https://code.google.com/p/dart/source/detail?r=6027

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -26 lines)			Patch
	M	dart/frog/tests/native/native.status	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
	M	dart/lib/compiler/implementation/native_handler.dart	View	1	5 chunks	+36 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/9909011/diff/1/dart/lib/compiler/implementation/native_handler.dart File dart/lib/compiler/implementation/native_handler.dart (left): https://chromiumcodereview.appspot.com/9909011/diff/1/dart/lib/compiler/implementation/native_handler.dart#oldcode184 dart/lib/compiler/implementation/native_handler.dart:184: ClassElement cls = compiler.coreLibrary.find( this is not necessary ...

8 years, 8 months ago (2012-03-29 23:25:51 UTC) #2

ngeoffray

8 years, 8 months ago (2012-03-30 09:30:19 UTC) #3

Thanks Florian

https://chromiumcodereview.appspot.com/9909011/diff/1/dart/lib/compiler/imple...
File dart/lib/compiler/implementation/native_handler.dart (left):

https://chromiumcodereview.appspot.com/9909011/diff/1/dart/lib/compiler/imple...
dart/lib/compiler/implementation/native_handler.dart:184: ClassElement cls =
compiler.coreLibrary.find(
On 2012/03/29 23:25:52, floitsch wrote:
> this is not necessary anymore, because the functions are now dart-code.
correct?

Correct.

https://chromiumcodereview.appspot.com/9909011/diff/1/dart/lib/compiler/imple...
File dart/lib/compiler/implementation/native_handler.dart (right):

https://chromiumcodereview.appspot.com/9909011/diff/1/dart/lib/compiler/imple...
dart/lib/compiler/implementation/native_handler.dart:193: Element element =
compiler.findHelper(
On 2012/03/29 23:25:52, floitsch wrote:
> Are you sure this doesn't fit on one line?
> If not, break after '='.

Done.

Expand Messages | Collapse Messages