Issue 9887003: Update reasons for some failing tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9887003: Update reasons for some failing tests. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update reasons for some failing tests. Also remove status-file lines for non-existing tests. Committed: https://code.google.com/p/dart/source/detail?r=5966

Patch Set 2 : Another status update. #

Patch Set 4 : Address comment. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	tests/language/language-leg.status	View	1 2 3	3 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! Thank you for keeping it tidy! Cheers, Peter https://chromiumcodereview.appspot.com/9887003/diff/4002/tests/language/language-leg.status File tests/language/language-leg.status (right): https://chromiumcodereview.appspot.com/9887003/diff/4002/tests/language/language-leg.status#newcode211 tests/language/language-leg.status:211: ...

8 years, 9 months ago (2012-03-29 05:13:01 UTC) #4

floitsch

8 years, 9 months ago (2012-03-29 05:30:41 UTC) #5

https://chromiumcodereview.appspot.com/9887003/diff/4002/tests/language/langu...
File tests/language/language-leg.status (right):

https://chromiumcodereview.appspot.com/9887003/diff/4002/tests/language/langu...
tests/language/language-leg.status:211: RegExp3Test: Fail, OK # Expects
exception from RegExp constructor.
On 2012/03/29 05:13:02, ahe wrote:
> Well, the problem is still that the test expects that a *const* constructor
> throws an exception. However, the const constructor cannot throw an exception
> unless we add additional magic to the language.

Ok. reverted.