Issue 9877008: Move the DOMContentLoaded logic into the generated JavaScript

Issue 9877008: Move the DOMContentLoaded logic into the generated JavaScript (Closed)

Created:
8 years, 9 months ago by kasperl

Modified:
8 years, 9 months ago

Reviewers:
vsm, Siggi Cherem (dart-lang), ngeoffray

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move the DOMContentLoaded logic into the generated JavaScript code thus simplifying htmlconverter.py. Committed: https://code.google.com/p/dart/source/detail?r=5942

Patch Set 2 : #

Total comments: 3

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -29 lines)			Patch
M	client/tools/htmlconverter.py	View		2 chunks	+3 lines, -20 lines	2 comments	Download
M	frog/gen.dart	View		1 chunk	+7 lines, -1 line	1 comment	Download
M	frog/minfrog	View		3 chunks	+15 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/emitter.dart	View	1	3 chunks	+18 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm! https://chromiumcodereview.appspot.com/9877008/diff/3001/client/tools/htmlconverter.py File client/tools/htmlconverter.py (right): https://chromiumcodereview.appspot.com/9877008/diff/3001/client/tools/htmlconverter.py#newcode44 client/tools/htmlconverter.py:44: main() => original.main(); I think we can just ...

8 years, 9 months ago (2012-03-28 17:17:57 UTC) #3

kasperl

https://chromiumcodereview.appspot.com/9877008/diff/3001/client/tools/htmlconverter.py File client/tools/htmlconverter.py (right): https://chromiumcodereview.appspot.com/9877008/diff/3001/client/tools/htmlconverter.py#newcode44 client/tools/htmlconverter.py:44: main() => original.main(); On 2012/03/28 17:17:57, vsm wrote: > ...

8 years, 9 months ago (2012-03-28 17:56:29 UTC) #4

lgtm

Expand Messages | Collapse Messages