Remove error message when compile time constants used in +,-,/,* expressions

Remove error message when compile time constants used in +,-,/,* expressions

The type of sub expressions was computed to be 'number' for 
integer math expressions.  This caused an inappropriate
error message 'Not a compile time constant, expected int, got num'

Committed: https://code.google.com/p/dart/source/detail?r=5939

[zundel, 2012-03-27 22:22:25]

I found this bug when trying to analyze a performance test.

[scheglov, 2012-03-27 22:39:21]

LGTM

https://chromiumcodereview.appspot.com/9875002/diff/2001/compiler/javatests/c...
File
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java
(right):

https://chromiumcodereview.appspot.com/9875002/diff/2001/compiler/javatests/c...
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java:572:
public void testParenthizedMathExpressions3() {
Do we want to have successful case for
int + double => num ?

[zundel, 2012-03-28 15:35:14]

On 2012/03/27 22:39:21, scheglov wrote:
> LGTM
> 
>
https://chromiumcodereview.appspot.com/9875002/diff/2001/compiler/javatests/c...
> File
>
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java
> (right):
> 
>
https://chromiumcodereview.appspot.com/9875002/diff/2001/compiler/javatests/c...
>
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java:572:
> public void testParenthizedMathExpressions3() {
> Do we want to have successful case for
> int + double => num ?

I don't think it works that way at runtime, but isn't really specified in the
spec.  int + double should equal double, so I made an update to the analyzer and
added another test.  The test really doesn't make sure its a double, but it does
make sure there are no warnings.

[scheglov, 2012-03-28 16:35:57]

LGTM