Fix for tooltips for fields not returning their types (just their name).

Fix for tooltips for fields not returning their types (just their name).
Committed: https://code.google.com/p/dart/source/detail?r=5958

[devoncarew, 2012-03-28 14:41:00]

This is a partial fix for field tooltips not showing their type ("foo" instead
of "int foo").

I think there's an issue in the resolution phase. Any pointers to where to
address that issue would be much appreciated!

This CL also addresses a few compiler warnings.

http://codereview.chromium.org/9874019/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/ast/DartFieldDefinition.java
(right):

http://codereview.chromium.org/9874019/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/ast/DartFieldDefinition.java:42: if
(typeNode.getType() == null) {
This currently always returns null. I assume that the resolution phase is never
resolving the type for the typeNode field. I'm not sure where to plumb this in -

[Brian Wilkerson, 2012-03-28 14:46:22]

LGTM

[zundel, 2012-03-28 15:48:39]

http://codereview.chromium.org/9874019/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/ast/DartFieldDefinition.java
(right):

http://codereview.chromium.org/9874019/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/ast/DartFieldDefinition.java:38: public
Type getType() {
Would it work to use:

node.getElement().getType()  

Traditionally we've been going through the element model to get type information
instead of adding getters on the AST nodes.

[devoncarew, 2012-03-28 20:10:35]

http://codereview.chromium.org/9874019/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/ast/DartFieldDefinition.java
(right):

http://codereview.chromium.org/9874019/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/ast/DartFieldDefinition.java:38: public
Type getType() {
On 2012/03/28 15:48:39, zundel wrote:
> Would it work to use:
> 
> node.getElement().getType()  
> 
> Traditionally we've been going through the element model to get type
information
> instead of adding getters on the AST nodes.

Hmm, I'm not totally sure I understand. This method is overridding an existing
getter on the parent class, which CompilationUnitImpl is already calling. I'm
just providing an implementation for it.

[zundel, 2012-03-28 22:19:43]

http://codereview.chromium.org/9874019/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/ast/DartFieldDefinition.java
(right):

http://codereview.chromium.org/9874019/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/ast/DartFieldDefinition.java:38: public
Type getType() {
On 2012/03/28 20:10:35, devoncarew wrote:
> On 2012/03/28 15:48:39, zundel wrote:
> > Would it work to use:
> > 
> > node.getElement().getType()  
> > 
> > Traditionally we've been going through the element model to get type
> information
> > instead of adding getters on the AST nodes.
> 
> Hmm, I'm not totally sure I understand. This method is overridding an existing
> getter on the parent class, which CompilationUnitImpl is already calling. I'm
> just providing an implementation for it.

I'm saying that there is already a way to get the type.  We don't normally
override this method for each AST node.

[devoncarew, 2012-03-28 22:25:35]

http://codereview.chromium.org/9874019/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/ast/DartFieldDefinition.java
(right):

http://codereview.chromium.org/9874019/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/ast/DartFieldDefinition.java:38: public
Type getType() {
Ah, ok. I'll back this change out.

Brian and tracked down the tooltip issue, in some code that converts the ASTs
into our light-weight model. I'll land what remains of this CL anyway, to clean
up some compilation warnings.