Issue 9873014: Factor out super-class and interface array subtype checks into a stub.

Issue 9873014: Factor out super-class and interface array subtype checks into a stub. (Closed)

Created:
8 years, 9 months ago by srdjan

Modified:
8 years, 9 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Factor out super-class and interface array subtype checks into a stub. Inline more type checks. Committed: https://code.google.com/p/dart/source/detail?r=5934

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -40 lines)			Patch
M	runtime/vm/code_generator_ia32.cc	View	1 2 3 4 5 6 7	4 chunks	+45 lines, -40 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4 5 6 7	2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code.h	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3 4 5 6 7	1 chunk	+79 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2 3 4 5 6 7	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

This is it for quick improvements of checked mode (time for running frogc.dart with frog ...

8 years, 9 months ago (2012-03-28 01:33:37 UTC) #1

regis

LGTM It's good that you introduced a stub. I worry that the code in checked ...

8 years, 9 months ago (2012-03-28 02:22:45 UTC) #2

srdjan

8 years, 9 months ago (2012-03-28 15:42:15 UTC) #3

https://chromiumcodereview.appspot.com/9873014/diff/4006/runtime/vm/code_gene...
File runtime/vm/code_generator_ia32.cc (right):

https://chromiumcodereview.appspot.com/9873014/diff/4006/runtime/vm/code_gene...
runtime/vm/code_generator_ia32.cc:1657: // Check superclasses.
On 2012/03/28 02:22:45, regis wrote:
> Is this comment left over?

Removed.

https://chromiumcodereview.appspot.com/9873014/diff/4006/runtime/vm/stub_code.h
File runtime/vm/stub_code.h (right):

https://chromiumcodereview.appspot.com/9873014/diff/4006/runtime/vm/stub_code...
runtime/vm/stub_code.h:36: V(IsSubType)                                         
                       \
On 2012/03/28 02:22:45, regis wrote:
> The name is somewhat misleading. How about IsRawSubType?

Renamed

Expand Messages | Collapse Messages