Move member-iterating code into ClassElement.

Move member-iterating code into ClassElement.

Committed: https://code.google.com/p/dart/source/detail?r=6007

[ngeoffray, 2012-03-28 15:05:37]

looks good! Adding ahe@ and karlklose@, who may also be interested in reviewing
this change.

[karlklose, 2012-03-29 10:48:04]

LGTM.

https://chromiumcodereview.appspot.com/9873012/diff/1/frog/leg/elements/eleme...
File frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9873012/diff/1/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:801: 
I would remove this line, the structure of the loop is clear enough.

https://chromiumcodereview.appspot.com/9873012/diff/1/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:824: includeSuperMembers);
This indentation looks strange. Use the parameter names, or something like this:

forEachMember(
  (ClassElement enclosingClass, Element member) {
    if (member.isInstanceMember() &&
        member.kind == ElementKind.FIELD) {
      f(enclosingClass, member);
    }
  }, includeBackendMembers, includeSuperMembers);

[floitsch, 2012-03-29 22:44:50]

https://chromiumcodereview.appspot.com/9873012/diff/1/frog/leg/elements/eleme...
File frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9873012/diff/1/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:801: 
On 2012/03/29 10:48:04, karlklose wrote:
> I would remove this line, the structure of the loop is clear enough.

Done.

https://chromiumcodereview.appspot.com/9873012/diff/1/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:824: includeSuperMembers);
On 2012/03/29 10:48:04, karlklose wrote:
> This indentation looks strange. Use the parameter names, or something like
this:
> 
> forEachMember(
>   (ClassElement enclosingClass, Element member) {
>     if (member.isInstanceMember() &&
>         member.kind == ElementKind.FIELD) {
>       f(enclosingClass, member);
>     }
>   }, includeBackendMembers, includeSuperMembers);

Moved function out of the call.
If you disagree with the name (fieldFilter) I can change it in another CL.

[ahe, 2012-04-19 10:02:31]

DBC

https://chromiumcodereview.appspot.com/9873012/diff/5001/lib/compiler/impleme...
File lib/compiler/implementation/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9873012/diff/5001/lib/compiler/impleme...
lib/compiler/implementation/elements/elements.dart:788: void forEachMember([void
f(ClassElement enclosingClass, Element member),
Why is f optional?

https://chromiumcodereview.appspot.com/9873012/diff/5001/lib/compiler/impleme...
lib/compiler/implementation/elements/elements.dart:815: void
forEachInstanceField([void f(ClassElement enclosingClass, Element field),
Ditto.

[floitsch, 2012-04-19 10:41:32]

https://chromiumcodereview.appspot.com/9873012/diff/5001/lib/compiler/impleme...
File lib/compiler/implementation/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9873012/diff/5001/lib/compiler/impleme...
lib/compiler/implementation/elements/elements.dart:788: void forEachMember([void
f(ClassElement enclosingClass, Element member),
On 2012/04/19 10:02:31, ahe wrote:
> Why is f optional?

So that you can give it a name and put it last.
It is completely unreadable when the function is first.

[ahe, 2012-04-19 10:43:58]

https://chromiumcodereview.appspot.com/9873012/diff/5001/lib/compiler/impleme...
File lib/compiler/implementation/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9873012/diff/5001/lib/compiler/impleme...
lib/compiler/implementation/elements/elements.dart:788: void forEachMember([void
f(ClassElement enclosingClass, Element member),
On 2012/04/19 10:41:32, floitsch wrote:
> On 2012/04/19 10:02:31, ahe wrote:
> > Why is f optional?
> 
> So that you can give it a name and put it last.
> It is completely unreadable when the function is first.

I see.