Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 987223002: Discard unused nesting levels. (Closed)

Created:
5 years, 9 months ago by Bob Nystrom
Modified:
5 years, 9 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Discard unused nesting levels. This avoids the line splitter trying nesting levels that will never be selected. On some pathologically deeply nested code, this can make a huge (1000x) perf difference. Most code is unaffected code, but this still make a 10% overall improvement on the original benchmark that didn't stress the worst case performance of this. R=pquitslund@google.com Committed: db6b9bfb6594ea095278d50aed164a096a09346f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -5 lines) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M benchmark/after.dart.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M benchmark/before.dart.txt View 1 chunk +29 lines, -0 lines 0 comments Download
M lib/src/chunk.dart View 4 chunks +4 lines, -5 lines 0 comments Download
M lib/src/line_splitter.dart View 3 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
This doesn't fix the performance problem on pathologically nested code, but it makes a big ...
5 years, 9 months ago (2015-03-09 23:02:38 UTC) #2
pquitslund
lgtm. Thanks!
5 years, 9 months ago (2015-03-09 23:51:47 UTC) #3
Bob Nystrom
5 years, 9 months ago (2015-03-10 01:14:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db6b9bfb6594ea095278d50aed164a096a09346f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698