leg pad (similar to frogpad, but for leg)

add legpad


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=5860

[mattsh, 2012-03-26 21:29:44]

This enables us to run dart2js in the browser (which makes it easy to step
through leg in any javascript debugger).

[floitsch, 2012-03-26 22:07:05]

LGTM.

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
File tools/testing/legpad/legpad.dart (right):

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:24: // id of script element containing name of
the main dart file
Id and finish sentence with '.'.

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:25: // to compile
Unless I'm wrong this is the Id of the script element that contains the code
that should be compiled (no files involved).

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:28: // accumulates diagnostic messages emitted
by the leg compiler
ditto: start with uppercase and finish with '.'.

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:29: String warnings = "";
Make it a StringBuffer?

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:35: // TODO - currently leg is confused about
where these two files
TODO(ldap) or TODO(issue-number). Followed by ":".

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:41: print("read $filename (${text.length}
bytes)");
debug code?

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:68: int time1 = new Date.now().value;
use Stopwatch class instead.

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:74: "${((time2 - time1) /
1000).toStringAsPrecision(3)} seconds";
toStringAsFixed?

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:92: output = futureJavascript.value;
You can't assume that the future has completed.
Either pass in a closure to runLeg, or return the future and let 'go' register
the 'then' part.

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:111: // TODO: should exist in standard lib
somewhere
TODO(ldap)

[ahe, 2012-03-26 22:22:06]

I'll take a closer look tomorrow. I think you found a sharp corner that needs a
bit of sanding.

https://chromiumcodereview.appspot.com/9866007/diff/3/tools/testing/legpad/le...
File tools/testing/legpad/legpad.dart (right):

https://chromiumcodereview.appspot.com/9866007/diff/3/tools/testing/legpad/le...
tools/testing/legpad/legpad.dart:35: // TODO - leg is confused about where this
file is
I think I know what the problem is. See below.

https://chromiumcodereview.appspot.com/9866007/diff/3/tools/testing/legpad/le...
tools/testing/legpad/legpad.dart:81: new
uri_lib.Uri.fromString("dartdir/frog/leg/lib");
Leg is not confused :-)

The URI must end with a slash. Otherwise uri.resolve doesn't work. 

We should document and possibly test this in the compile method. Mind filing a
bug, I'm on phone now and it is hard to create a bug report from the small
screen.

[mattsh, 2012-03-27 02:30:25]

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
File tools/testing/legpad/legpad.dart (right):

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:25: // to compile
On 2012/03/26 22:07:05, floitsch wrote:
> Unless I'm wrong this is the Id of the script element that contains the code
> that should be compiled (no files involved).

(just chatted offline, yes, this is in fact the file name)

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:29: String warnings = "";
On 2012/03/26 22:07:05, floitsch wrote:
> Make it a StringBuffer?

Done.

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:35: // TODO - currently leg is confused about
where these two files
On 2012/03/26 22:07:05, floitsch wrote:
> TODO(ldap) or TODO(issue-number). Followed by ":".

Done.

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:92: output = futureJavascript.value;
On 2012/03/26 22:07:05, floitsch wrote:
> You can't assume that the future has completed.
> Either pass in a closure to runLeg, or return the future and let 'go' register
> the 'then' part.

added TODO for compiler to add synchronous API.

https://chromiumcodereview.appspot.com/9866007/diff/2001/tools/testing/legpad...
tools/testing/legpad/legpad.dart:111: // TODO: should exist in standard lib
somewhere
On 2012/03/26 22:07:05, floitsch wrote:
> TODO(ldap)

Done.