Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issue 9861011: - Remove type arguments from internal classes and interfaces. (Closed)

Created:
8 years, 9 months ago by Ivan Posva
Modified:
8 years, 8 months ago
Reviewers:
dcarlson, srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Remove type arguments from internal classes and interfaces. Committed: https://code.google.com/p/dart/source/detail?r=5920

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -29 lines) Patch
M lib/utf/utf16.dart View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M lib/utf/utf32.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M lib/utf/utf8.dart View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M lib/utf/utf_core.dart View 1 2 7 chunks +24 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
8 years, 9 months ago (2012-03-27 01:20:33 UTC) #1
Ivan Posva
There is no need to be extra generic for these internal types. Srdjan measured a ...
8 years, 9 months ago (2012-03-28 00:07:47 UTC) #2
srdjan
LGTM
8 years, 9 months ago (2012-03-28 00:08:56 UTC) #3
dcarlson
8 years, 8 months ago (2012-03-28 14:16:33 UTC) #4
lgtm

LGTM.

Powered by Google App Engine
This is Rietveld 408576698