Issue 9859001: Fix broken directory test using undefined class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9859001: Fix broken directory test using undefined class (Closed)

Created:
8 years, 9 months ago by Søren Gjesse

Modified:
8 years, 9 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix broken directory test using undefined class R=ahe@google.com BUG=none TEST=tests/standalone/src/io/DirectoryInvalidArgumentsTest.dart Committed: https://code.google.com/p/dart/source/detail?r=5817

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	tests/standalone/src/io/DirectoryInvalidArgumentsTest.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tests/standalone/standalone-leg.status	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 9 months ago (2012-03-26 07:16:58 UTC) #2

Thank you, Søren

LGTM!

Cheers,
Peter

https://chromiumcodereview.appspot.com/9859001/diff/1/tests/standalone/standa...
File tests/standalone/standalone-leg.status (left):

https://chromiumcodereview.appspot.com/9859001/diff/1/tests/standalone/standa...
tests/standalone/standalone-leg.status:13: io/DirectoryInvalidArgumentsTest:
Fail, OK # Broken test: DirectoryException does not exist
Sorry for not letting you know directly. I am planning on running through all
the leg status files and report bugs regarding broken tests.

Expand Messages | Collapse Messages