Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 9856020: Print the actual error message on failure in the ProcessStartException test. (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Print the actual error message on failure in the ProcessStartException test. R=iposva@google.com,sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5842

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/standalone/src/io/ProcessStartExceptionTest.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
8 years, 9 months ago (2012-03-26 16:13:19 UTC) #1
Ivan Posva
LGTM with comment. -Ivan https://chromiumcodereview.appspot.com/9856020/diff/1/tests/standalone/src/io/ProcessStartExceptionTest.dart File tests/standalone/src/io/ProcessStartExceptionTest.dart (right): https://chromiumcodereview.appspot.com/9856020/diff/1/tests/standalone/src/io/ProcessStartExceptionTest.dart#newcode21 tests/standalone/src/io/ProcessStartExceptionTest.dart:21: Expect.equals(2, e.errorCode, '$e'); What's wrong ...
8 years, 9 months ago (2012-03-26 16:48:18 UTC) #2
Mads Ager (google)
https://chromiumcodereview.appspot.com/9856020/diff/1/tests/standalone/src/io/ProcessStartExceptionTest.dart File tests/standalone/src/io/ProcessStartExceptionTest.dart (right): https://chromiumcodereview.appspot.com/9856020/diff/1/tests/standalone/src/io/ProcessStartExceptionTest.dart#newcode21 tests/standalone/src/io/ProcessStartExceptionTest.dart:21: Expect.equals(2, e.errorCode, '$e'); On 2012/03/26 16:48:18, Ivan Posva wrote: ...
8 years, 9 months ago (2012-03-26 16:52:00 UTC) #3
Søren Gjesse
8 years, 9 months ago (2012-03-27 07:05:28 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698