Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 9855012: Fix file error tests on Windows (Closed)

Created:
8 years, 9 months ago by Søren Gjesse
Modified:
8 years, 9 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix file error tests on Windows * Always close files before deleting the temporary test directory * Truncate on read only fils only fails if the file is not empty TBR=ager@google.com BUG=none TEST=tests/standalone/src/io/FileErrorTest.dart Committed: https://code.google.com/p/dart/source/detail?r=5814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M tests/standalone/src/io/FileErrorTest.dart View 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years, 9 months ago (2012-03-26 06:31:58 UTC) #1
Mads Ager (google)
8 years, 9 months ago (2012-03-26 15:23:16 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698