Issue 9845040: - Make the URI resolution methods used by the tag handler private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9845040: - Make the URI resolution methods used by the tag handler private. (Closed)

Created:
8 years, 9 months ago by Ivan Posva

Modified:
8 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Make the URI resolution methods used by the tag handler private. Committed: https://code.google.com/p/dart/source/detail?r=5921

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -31 lines)			Patch
M	runtime/bin/builtin.dart	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/main.cc	View	1	5 chunks	+11 lines, -21 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	1 chunk	+19 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/9845040/diff/1/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://chromiumcodereview.appspot.com/9845040/diff/1/runtime/bin/builtin.dart#newcode37 runtime/bin/builtin.dart:37: // TODO(iposva): Make these private once the Dart ...

8 years, 9 months ago (2012-03-23 22:48:46 UTC) #2

Ivan Posva

8 years, 9 months ago (2012-03-28 01:20:31 UTC) #3

https://chromiumcodereview.appspot.com/9845040/diff/1/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://chromiumcodereview.appspot.com/9845040/diff/1/runtime/bin/builtin.dar...
runtime/bin/builtin.dart:37: // TODO(iposva): Make these private once the Dart
API is fixed.
On 2012/03/23 22:48:46, srdjan wrote:
> Remove TODO

Done.

Expand Messages | Collapse Messages

Issue 9845040: - Make the URI resolution methods used by the tag handler private. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages