add disqus comments

add disqus comments


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=6055

[sethladd, 2012-03-28 19:20:23]

ptal

staged at http://9.dartlang-api.appspot.com/

[Bob Nystrom, 2012-03-28 20:01:21]

Couple of comments, but looks pretty good. I'd like a cleaner API for apidoc to
extend dartdoc at some point, but what you're doing here is fine for now.

https://chromiumcodereview.appspot.com/9844031/diff/1/lib/dartdoc/dartdoc.dart
File lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/9844031/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:170: 
Why move these here?

https://chromiumcodereview.appspot.com/9844031/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:426: <script async
src="${relativePath('$clientScript.js')}"></script>
\o/

https://chromiumcodereview.appspot.com/9844031/diff/1/utils/apidoc/README.txt
File utils/apidoc/README.txt (right):

https://chromiumcodereview.appspot.com/9844031/diff/1/utils/apidoc/README.txt...
utils/apidoc/README.txt:2: dartdoc generates static HTML documentation from Dart
code.
I would capitalize "Dartdoc" here since it starts the sentence.

https://chromiumcodereview.appspot.com/9844031/diff/1/utils/apidoc/apidoc.dart
File utils/apidoc/apidoc.dart (right):

https://chromiumcodereview.appspot.com/9844031/diff/1/utils/apidoc/apidoc.dar...
utils/apidoc/apidoc.dart:82: final clientScript = (mode ==
doc.Dartdoc.MODE_STATIC) ? 'static' : 'live-nav';
Long line.

https://chromiumcodereview.appspot.com/9844031/diff/1/utils/apidoc/apidoc.dar...
utils/apidoc/apidoc.dart:121: if (mode != null) apidoc.mode = mode;
Sicne we pass in the output directory, how about passing in the mode too? Also,
the null check isn't needed since it's always initialized.

https://chromiumcodereview.appspot.com/9844031/diff/1/utils/apidoc/apidoc.dar...
utils/apidoc/apidoc.dart:129: final String disqusShortname = 'dartapidocs';
Ditch the type annotation since it's obvious from the initializer. Also, make
static?

[sethladd, 2012-03-28 21:52:11]

https://chromiumcodereview.appspot.com/9844031/diff/1/lib/dartdoc/dartdoc.dart
File lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/9844031/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:170: 
Good question, I think I was trying something else and then abandoned the path.

https://chromiumcodereview.appspot.com/9844031/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:426: <script async
src="${relativePath('$clientScript.js')}"></script>
On 2012/03/28 20:01:21, Bob Nystrom wrote:
> \o/

Done.

https://chromiumcodereview.appspot.com/9844031/diff/1/utils/apidoc/README.txt
File utils/apidoc/README.txt (right):

https://chromiumcodereview.appspot.com/9844031/diff/1/utils/apidoc/README.txt...
utils/apidoc/README.txt:2: dartdoc generates static HTML documentation from Dart
code.
On 2012/03/28 20:01:21, Bob Nystrom wrote:
> I would capitalize "Dartdoc" here since it starts the sentence.

Done.

https://chromiumcodereview.appspot.com/9844031/diff/1/utils/apidoc/apidoc.dart
File utils/apidoc/apidoc.dart (right):

https://chromiumcodereview.appspot.com/9844031/diff/1/utils/apidoc/apidoc.dar...
utils/apidoc/apidoc.dart:82: final clientScript = (mode ==
doc.Dartdoc.MODE_STATIC) ? 'static' : 'live-nav';
On 2012/03/28 20:01:21, Bob Nystrom wrote:
> Long line.

Done.

https://chromiumcodereview.appspot.com/9844031/diff/1/utils/apidoc/apidoc.dar...
utils/apidoc/apidoc.dart:129: final String disqusShortname = 'dartapidocs';
On 2012/03/28 20:01:21, Bob Nystrom wrote:
> Ditch the type annotation since it's obvious from the initializer. Also, make
> static?

Done.

[Bob Nystrom, 2012-03-28 23:32:58]

Added another comment. Also, what about the other ones I left on the first patch
that you didn't reply to? Haven't gotten to them yet?

https://chromiumcodereview.appspot.com/9844031/diff/5002/utils/apidoc/apidoc....
File utils/apidoc/apidoc.dart (right):

https://chromiumcodereview.appspot.com/9844031/diff/5002/utils/apidoc/apidoc....
utils/apidoc/apidoc.dart:35: /*
Delete this.

[sethladd, 2012-03-29 00:15:28]

Sorry, I think I missed one comment previously. Unless there's a secret cache of
comments?

I've uploaded another patch.

https://chromiumcodereview.appspot.com/9844031/diff/1/utils/apidoc/apidoc.dart
File utils/apidoc/apidoc.dart (right):

https://chromiumcodereview.appspot.com/9844031/diff/1/utils/apidoc/apidoc.dar...
utils/apidoc/apidoc.dart:121: if (mode != null) apidoc.mode = mode;
On 2012/03/28 20:01:21, Bob Nystrom wrote:
> Sicne we pass in the output directory, how about passing in the mode too?
Also,
> the null check isn't needed since it's always initialized.

Done.

https://chromiumcodereview.appspot.com/9844031/diff/5002/utils/apidoc/apidoc....
File utils/apidoc/apidoc.dart (right):

https://chromiumcodereview.appspot.com/9844031/diff/5002/utils/apidoc/apidoc....
utils/apidoc/apidoc.dart:35: /*
good catch, thx

[Bob Nystrom, 2012-03-29 00:22:54]

One nit, and can you move those mode constants back out of the Dartdoc class?

Assuming you do those, LGTM.

https://chromiumcodereview.appspot.com/9844031/diff/11001/utils/apidoc/apidoc...
File utils/apidoc/apidoc.dart (right):

https://chromiumcodereview.appspot.com/9844031/diff/11001/utils/apidoc/apidoc...
utils/apidoc/apidoc.dart:124: Apidoc(this.mdn, String outputDir, int
sideBarGenerationMode) {
Just call this "mode" since we will likely use it for non-sidebar-related "mode"
stuff at some point, I think.

[sethladd, 2012-03-29 07:36:32]

Note that this won't work due to conflict with Frog code and Disqus. I am
testing if dart2js is better.

https://chromiumcodereview.appspot.com/9844031/diff/11001/utils/apidoc/apidoc...
File utils/apidoc/apidoc.dart (right):

https://chromiumcodereview.appspot.com/9844031/diff/11001/utils/apidoc/apidoc...
utils/apidoc/apidoc.dart:124: Apidoc(this.mdn, String outputDir, int
sideBarGenerationMode) {
On 2012/03/29 00:22:54, Bob Nystrom wrote:
> Just call this "mode" since we will likely use it for non-sidebar-related
"mode"
> stuff at some point, I think.

Done.