Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 9844022: Fix for a windows path issue. (Closed)

Created:
8 years, 9 months ago by devoncarew
Modified:
8 years, 9 months ago
Reviewers:
zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for a windows path issue. Committed: https://code.google.com/p/dart/source/detail?r=5936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M compiler/java/com/google/dart/compiler/SystemLibraryManager.java View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
devoncarew
8 years, 9 months ago (2012-03-28 15:51:34 UTC) #1
zundel
LGTM Did you try running dartc tests locally? cd <dart trunk> ./tools/build.py ./tools/test.py -c dartc ...
8 years, 9 months ago (2012-03-28 15:56:30 UTC) #2
devoncarew
8 years, 9 months ago (2012-03-28 16:58:52 UTC) #3
> Did you try running dartc tests locally?

I just ran them, they passed with flying colors.

Powered by Google App Engine
This is Rietveld 408576698